Fix invalid SQL on DELETE with backward relations/joins#2217
Open
sumit-raghav-06 wants to merge 2 commits into
Open
Fix invalid SQL on DELETE with backward relations/joins#2217sumit-raghav-06 wants to merge 2 commits into
sumit-raghav-06 wants to merge 2 commits into
Conversation
sumit-raghav-06
commented
Jun 18, 2026
sumit-raghav-06
left a comment
Author
There was a problem hiding this comment.
guide me if anything wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored the
DeleteQuery._make_querymethod to handle deletions when filtering across relations or implicit filters that require a tableJOIN.Modern SQL backends like PostgreSQL and SQLite do not natively support standard
DELETE FROM table LEFT JOIN ...syntax. This fix detects if joins are present (self._joined_tables) and refactors the statement into a clean, isolatedINsubquery fallback.Motivation and Context
This fixes an issue where running a
.delete()on queries involving backward relations or joined filters throws an operational/syntax error on PostgreSQL and SQLiteHow Has This Been Tested?
WHERE id IN (SELECT ...)subquery format and execute without syntax errorsChecklist: