Skip to content

fix: use light foreground color on live stream page for spectrogram#2863

Merged
tphakala merged 1 commit intotphakala:mainfrom
rexxars:fix/live-stream-foreground-color
Apr 28, 2026
Merged

fix: use light foreground color on live stream page for spectrogram#2863
tphakala merged 1 commit intotphakala:mainfrom
rexxars:fix/live-stream-foreground-color

Conversation

@rexxars
Copy link
Copy Markdown
Contributor

@rexxars rexxars commented Apr 26, 2026

On the live stream page, if you're using light mode, it is very hard to see the play button/"Audio Source" text. See below for comparison.

light mode dark mode
image image

This PR standardizes on light foreground color for this spectrogram, since it's overlayed on a black background

Summary by CodeRabbit

  • Style
    • Enhanced the start button appearance on the live stream page with improved text color contrast and clearer hover state visibility for better user interaction feedback.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4a0b906d-3c94-46e6-b9f2-a8ee582b1c68

📥 Commits

Reviewing files that changed from the base of the PR and between 9a9cde7 and 2d7f813.

📒 Files selected for processing (1)
  • frontend/src/lib/desktop/features/live-stream/pages/LiveStreamPage.svelte

Walkthrough

A CSS styling update to the start button in the LiveStreamPage component, changing the text color class from using --color-base-content with opacity to an explicit text-white/75 class with hover state.

Changes

Cohort / File(s) Summary
Live Stream Page Styling
frontend/src/lib/desktop/features/live-stream/pages/LiveStreamPage.svelte
Updated start button CSS classes: replaced text-base-content/75 and hover:text-base-content with text-white/75 and hover:text-white for explicit white text color styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: switching from dark colors to light foreground colors on the live stream page for better visibility in light mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling of the start button on the Live Stream page, changing the text color and hover state to use white instead of theme variables. A review comment suggests refining the hover effect by using the "enabled:" modifier to prevent the hover style from appearing when the button is disabled, ensuring better visual feedback for users.

onclick={handleStartClick}
disabled={!selectedSourceId || sources.length === 0}
class="flex h-full w-full flex-col items-center justify-center gap-3 bg-black text-[var(--color-base-content)]/60 transition-colors hover:text-[var(--color-base-content)]/80 disabled:cursor-not-allowed disabled:opacity-50"
class="flex h-full w-full flex-col items-center justify-center gap-3 bg-black text-white/75 transition-colors hover:text-white disabled:cursor-not-allowed disabled:opacity-50"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The hover:text-white style will still trigger when the button is disabled, which can be confusing for users as it suggests interactivity. It's better to restrict the hover effect to the enabled state using the enabled: modifier.

          class="flex h-full w-full flex-col items-center justify-center gap-3 bg-black text-white/75 transition-colors enabled:hover:text-white disabled:cursor-not-allowed disabled:opacity-50"

@tphakala
Copy link
Copy Markdown
Owner

Nice catch, thanks for fixing this. The white text on the black spectrogram background is the right call here.

@tphakala tphakala merged commit 84e5cc3 into tphakala:main Apr 28, 2026
15 checks passed
@rexxars rexxars deleted the fix/live-stream-foreground-color branch April 28, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants