[pull] master from golang:master#122
Merged
Merged
Conversation
All other dirFS methods (Open, ReadFile, ReadDir, Stat, Lstat) rewrite
PathError.Path to the relative name on error. Do the same in
dirFS.ReadLink to be consistent and so callers of
DirFS("/prefix").ReadLink("file") see PathError{Path: "file"} instead of
PathError{Path: "/prefix/file"}.
Change-Id: Id49cb43d79f459c855f94e5544e4c727fe68a7b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/796540
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currenty `go fmt` does not truncate the symlinked file, as it compares the size of the recorded data not with the real file size, but with the symlink reference path length. Fixes #79735 Change-Id: I0cedccb061aa1a9844bce698c19cb0e96e2e3d14 GitHub-Last-Rev: 6126f26 GitHub-Pull-Request: #79774 Reviewed-on: https://go-review.googlesource.com/c/go/+/785800 Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Auto-Submit: Alan Donovan <adonovan@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )