fix(libafl): restart client after SIGSEGV - #151
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the LibAFL integration to keep fuzzing after a target SIGSEGV by pulling in an updated LibAFL-git-aware revision, and adds a regression example + CI smoke coverage to ensure the launcher restarts the client instead of treating the crash as a crash-handler failure.
Changes:
- Bump LibAFL-git-aware dependency (via
Cargo.lock) to include the SIGSEGV/crash-handler recursion fix. - Add a new
sigsegv_restartGo fuzzing example plus a dedicated LibAFL smoke test script. - Document that disabling
stop_all_fuzzers_on_panickeeps fuzzing and restarts the crashing client (includingSIGSEGV).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/gosentry/examples/sigsegv_restart/sigsegv.go | Adds a CGO helper that triggers SIGSEGV for regression testing. |
| test/gosentry/examples/sigsegv_restart/sigsegv_test.go | Adds a fuzz harness that deterministically triggers SIGSEGV from a seeded input. |
| test/gosentry/examples/sigsegv_restart/go.mod | Adds a module for the new SIGSEGV restart example. |
| README.md | Documents continued fuzzing + client restart behavior when stop_all_fuzzers_on_panic=false. |
| misc/gosentry/USE_LIBAFL.md | Documents client restart behavior after crashes (including SIGSEGV). |
| misc/gosentry/tests/smoke_use_libafl.sh | Wires the new SIGSEGV restart smoke test into the LibAFL smoke suite. |
| misc/gosentry/tests/smoke_use_libafl_sigsegv_restart.sh | New smoke test validating crash is saved and the client restarts after SIGSEGV. |
| golibafl/Cargo.lock | Updates the pinned LibAFL-git-aware git revision containing the fix. |
| .github/workflows/smoke_use_libafl.yml | Runs the new SIGSEGV restart smoke test in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| module sigsegv_restart | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149 by updating the LibAFL fork's signal-recursion exit check and adding a SIGSEGV restart regression test.