Skip to content

fix(plugins): drop unused gitBranch re-export from the package entry#3923

Merged
matt-aitken merged 1 commit into
mainfrom
fix/plugins-entry-no-runtime-core-import
Jun 12, 2026
Merged

fix(plugins): drop unused gitBranch re-export from the package entry#3923
matt-aitken merged 1 commit into
mainfrom
fix/plugins-entry-no-runtime-core-import

Conversation

@matt-aitken

Copy link
Copy Markdown
Member

@trigger.dev/plugins re-exported sanitizeBranchName/isValidGitBranchName from @trigger.dev/core as a convenience forwarder. Nothing actually imports them through this package — every consumer (webapp, @trigger.dev/rbac, …) imports them directly from @trigger.dev/core/v3/utils/gitBranch.

Removing the forwarder keeps the package entry free of runtime core imports (only type re-exports + buildJwtAbility remain), so consumers that bundle @trigger.dev/plugins from source don't pull an unrelated core subpath into their build.

No behavior change; the helpers remain available from @trigger.dev/core where they're defined.

@trigger.dev/plugins re-exported sanitizeBranchName/isValidGitBranchName
from @trigger.dev/core purely as a convenience forwarder. Nothing imports
them through this package — every consumer imports them directly from
@trigger.dev/core/v3/utils/gitBranch. Removing the forwarder keeps the
package entry free of runtime core imports, so consumers that bundle it
from source don't drag an unrelated core subpath into their build.
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0b606b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83866c18-35f6-402a-97f8-4e4082cb489a

📥 Commits

Reviewing files that changed from the base of the PR and between f48c897 and 0b606b4.

📒 Files selected for processing (1)
  • packages/plugins/src/index.ts
💤 Files with no reviewable changes (1)
  • packages/plugins/src/index.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: audit
  • GitHub Check: audit
  • GitHub Check: 🛡️ E2E Auth Tests (full)
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Build and publish previews

Walkthrough

This PR removes two convenience re-exports from the plugins package: sanitizeBranchName and isValidGitBranchName. These utilities, originally from @trigger.dev/core/v3/utils/gitBranch, were forwarded through packages/plugins/src/index.ts for plugin author convenience. The changes remove these re-exports without adding replacements.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the rationale but is missing required template sections: issue reference, testing details, and changelog entry. Add 'Closes #' reference, document testing steps under the Testing section, and provide changelog details in the Changelog section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing unused git branch re-exports from the plugins package entry point.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/plugins-entry-no-runtime-core-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@matt-aitken matt-aitken enabled auto-merge (squash) June 12, 2026 12:10
@matt-aitken matt-aitken merged commit eb498d1 into main Jun 12, 2026
50 checks passed
@matt-aitken matt-aitken deleted the fix/plugins-entry-no-runtime-core-import branch June 12, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants