fix(plugins): drop unused gitBranch re-export from the package entry#3923
Conversation
@trigger.dev/plugins re-exported sanitizeBranchName/isValidGitBranchName from @trigger.dev/core purely as a convenience forwarder. Nothing imports them through this package — every consumer imports them directly from @trigger.dev/core/v3/utils/gitBranch. Removing the forwarder keeps the package entry free of runtime core imports, so consumers that bundle it from source don't drag an unrelated core subpath into their build.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)
WalkthroughThis PR removes two convenience re-exports from the plugins package: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@trigger.dev/pluginsre-exportedsanitizeBranchName/isValidGitBranchNamefrom@trigger.dev/coreas a convenience forwarder. Nothing actually imports them through this package — every consumer (webapp,@trigger.dev/rbac, …) imports them directly from@trigger.dev/core/v3/utils/gitBranch.Removing the forwarder keeps the package entry free of runtime core imports (only type re-exports +
buildJwtAbilityremain), so consumers that bundle@trigger.dev/pluginsfrom source don't pull an unrelated core subpath into their build.No behavior change; the helpers remain available from
@trigger.dev/corewhere they're defined.