Skip to content

fix(cua-driver): expose legacy macOS page fallback#2356

Open
injaneity wants to merge 2 commits into
mainfrom
fix/issue-2245
Open

fix(cua-driver): expose legacy macOS page fallback#2356
injaneity wants to merge 2 commits into
mainfrom
fix/issue-2245

Conversation

@injaneity

Copy link
Copy Markdown
Collaborator

summary

  • preserve the legacy page.get_text and page.query_dom text payload while attaching macOS read provenance in structuredContent
  • label successful Apple Events reads as javascript, Electron reads as cdp, and direct or failure-driven AX reads as ax_fallback
  • preserve the triggering JavaScript/CDP error, report bounded AX truncation, and retain both errors if AX fallback also fails
  • document the compatibility-only fallback contract

fixes #2245

tests

  • cargo test -p cua-driver-core --lib
  • cargo test -p platform-macos tools::page::tests --lib
  • cargo fmt --all -- --check
  • git diff --check

cargo clippy -p cua-driver-core -p platform-macos --all-targets -- -D warnings remains blocked by pre-existing clippy errors in cursor-overlay, browser/engine.rs, browser/grant.rs, and recording code; none are in this change.

@injaneity
injaneity marked this pull request as ready for review July 19, 2026 17:41
@injaneity
injaneity requested a review from f-trycua as a code owner July 19, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cua-driver page (macOS): label AX fallback and preserve the JS/CDP error

1 participant