fix: support all OSC 52 selection types for clipboard sync#1518
Open
aaradhyaberisfdc wants to merge 1 commit intotsl0922:mainfrom
Open
fix: support all OSC 52 selection types for clipboard sync#1518aaradhyaberisfdc wants to merge 1 commit intotsl0922:mainfrom
aaradhyaberisfdc wants to merge 1 commit intotsl0922:mainfrom
Conversation
Replace default BrowserClipboardProvider with a custom provider that accepts all selection types. tmux sends OSC 52 with type 'p' (primary) which the default provider silently drops.
Author
|
@tsl0922 Could I please get a review whenever you get the time? |
Owner
|
Is it possible to submit it to the upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@xterm/addon-clipboard's defaultBrowserClipboardProvidersilently drops OSC 52 clipboard writes for any selection type other than'c'(system clipboard). See this.tmux sends selection type
'p'(primary) by default withset-clipboard on, so clipboard never reaches the browser.The addon's type definitions also have a mismatch (
constructor(provider?)in .d.ts vsconstructor(base64, provider)at runtime), requiring a@ts-expect-errorto pass a custom provider. See this.Proposed Fix
Replace the default
BrowserClipboardProviderwith a customTtydClipboardProviderthat accepts all OSC 52 selection types, browsers have a single clipboard with no primary/secondary distinction.Testing
tmux integration with
set -g set-clipboard onandset -g mouse on:y) copies to system clipboard