Logging service - #52
Open
MasterSushiChef wants to merge 90 commits into
Open
Conversation
…mes protobuf message
…logging-service
Combine service_ping and device_ping Added lumberjack to docker-compose
Added lumberjack to orchestra level make Added additional env variables to Dockerfile
…of task queue -Added getQueueLength to plane.js and router -Set pstatus to offline if greater than env variable, queueLimit
Member
|
This branch will be squashed into one big commit on merge. I know it's not ideal, but I have tried rebasing interactively and the new history always turns out to be just as messy as the old one. |
Logging test fix
oldmud0
reviewed
Feb 10, 2020
Comment on lines
-113
to
-115
| test('clear data', async () => { | ||
| expect(service.clearData()).toBeTruthy(); | ||
| }); |
oldmud0
reviewed
Nov 20, 2020
Comment on lines
+15
to
+17
| url: http://influx:8086 | ||
| # <string> database name, if used | ||
| database: ${DB_NAME} | ||
| database: lumberjack |
Member
There was a problem hiding this comment.
Hmm, I don't recommend changing this. It makes it more difficult to change hostnames and ports for alternate deployments. That is why we used the uavaustin/grafana image instead of the default grafana/grafana image.
Contributor
There was a problem hiding this comment.
I couldn't get the custom uavaustin/grafana image working. But for environment variable interpolation, base grafana allows us to do this. In the latest commit, I added back the environment variables in data sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still getting an undefined response from the requests in the service even if the urls are matching with the nocks