Provide coverage for an iterator cell case#1183
Open
isaacbrodsky wants to merge 3 commits into
Open
Conversation
isaacbrodsky
changed the title
_hex2dToVec3
|
coverage: 99.195% (+0.02%) from 99.176% — isaacbrodsky:cover-more-cases into uber:master |
dfellis
reviewed
Jun 27, 2026
| if (substrate) { | ||
| r *= M_ONETHIRD; | ||
| if (isResolutionClassIII(res)) r *= M_RSQRT7; | ||
| // Never occurs because every case where this function is called with |
Collaborator
There was a problem hiding this comment.
Is this PR accidentally including the other one?
Collaborator
Author
There was a problem hiding this comment.
Yes - that was supposed to be moved to #1184. I pushed the commit to remove from this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides coverage for a branch in iterators.c where the iterator is expecting to need to skip a child, but ultimately doesn't. The case is reachable if the iterator is modified by the caller, but not during normal operation. I didn't choose to mark it NEVER/ALWAYS because a caller using the iterators could potentially reach it.