PR 6: refactor: per-area small refactors (CTS, Scheduler, Students, CMS)

[rlorenzo]

Summary

Part 6 of 6. Stacks on top of PR #177 (parallel to PR #178). The smallest PR in the stack — 9 files, 4 self-contained refactors.

Each commit is a small per-area dedup driven by jscpd findings on the original code-anaylsis branch.

Commits

• refactor(cts): collapse hardcoded CourseStudents rows into a v-for — replace 5 near-identical <tr> blocks with a single v-for.
• refactor(scheduler): share schedule filter LINQ via IScheduleEntity — introduce IScheduleEntity + ScheduleQueryExtensions so the by-clinician / by-rotation / by-week scheduling queries share their filter LINQ.
• refactor(students): consolidate StudentGroupService photo + Ross helpers — extract BuildStudentPhotoListAsync, FormatStudentDisplayName, FormatGroupAssignment, ResolvePhotoUrl, and GetActiveRossIamIdsAsync so the by-class-level / by-group / by-course paths no longer hand-roll the same logic.
• refactor(cms): collapse Codecs UU/XX encoders onto shared map helpers — collapse 4 near-identical UU/XX encode/decode methods into 2 generic helpers (DecodeWithMap, EncodeWithMap) keyed by the encoding map.

Conflict resolution notes

Two cherry-picks needed conflict resolution because PR 3's analyzer cleanup ran ahead of these refactors in the original chronology, and the analyzer fixes touched the pre-refactor code shape:

• StudentGroupService.cs: took the refactor's structure, then re-applied PR 3's analyzer fixes to the new helper (SqlException short qualifier, !string.IsNullOrEmpty(id) over id != null, sealed record StudentBaseRecord).
• Codecs.cs: took the refactor's consolidated structure with Stream qualifiers shortened (the file's implicit-usings setup makes using System.IO; unnecessary).

Net effect: each file ends up at the same end-state as on the original code-anaylsis branch.

PR stack

• PR 1 → tooling: fallow + jscpd (PR 1: feat(tooling): add fallow + jscpd with regression-gated CI #174)
• PR 2 → tooling: CodeQL + Roslyn + ReSharper (PR 2: chore(quality): add C# analyzers + ReSharper PR gate #175)
• PR 3 → quality: bulk analyzer cleanup (PR 3: chore(quality): mechanical analyzer-driven cleanup (453 files) #176)
• PR 4 → refactor: dead-code + shared chrome (PR 4: refactor: dead-code removal + shared chrome extraction #177)
• PR 5 → refactor: Effort component extraction (PR 5: refactor(effort): component extraction + report context centralization #178)
• PR 6 (this) → refactor: per-area small

Test plan

• CI green
• CTS course students table renders correctly (5+ students)
• Clinical Scheduler: by-clinician / by-rotation / by-week views still filter the same set
• Students photo gallery: by-class-level / by-group / by-course flows match prior behavior; Ross students excluded/included as before
• CMS Codecs: round-trip a UU and XX encode/decode against a known fixture

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• review-ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c9fde0dd-7c47-46ee-babc-b34dbdcce0dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/per-area-small

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Bundle Report

Changes will decrease total bundle size by 881 bytes (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
viper-frontend-esm	2.14MB	-881 bytes (-0.04%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: viper-frontend-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
assets/CourseStudents-*.js	-881 bytes	1.95kB	-31.08%

Files in assets/CourseStudents-*.js:

• ./src/CTS/pages/CourseStudents.vue → Total Size: 145 bytes

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.18%. Comparing base (f45f6b7) to head (743f4e5).

Files with missing lines	Patch %	Lines
web/Areas/Students/Services/StudentGroupService.cs	0.00%	106 Missing ⚠️
web/Areas/CMS/Data/Codecs.cs	0.00%	34 Missing ⚠️
...nicalScheduler/Services/ScheduleQueryExtensions.cs	0.00%	31 Missing ⚠️
...calScheduler/Services/InstructorScheduleService.cs	0.00%	1 Missing ⚠️
...inicalScheduler/Services/StudentScheduleService.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   43.02%   43.18%   +0.16%     
==========================================
  Files         881      882       +1     
  Lines       51436    51242     -194     
  Branches     4812     4778      -34     
==========================================
  Hits        22131    22131              
+ Misses      28779    28585     -194     
  Partials      526      526              

Flag	Coverage Δ
backend	43.27% <0.00%> (+0.17%)	⬆️
frontend	41.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.