Skip to content

chore(build): harden dotnet build scripts and drop deprecated baseUrl#204

Merged
rlorenzo merged 1 commit into
mainfrom
chore/build-hardening
May 21, 2026
Merged

chore(build): harden dotnet build scripts and drop deprecated baseUrl#204
rlorenzo merged 1 commit into
mainfrom
chore/build-hardening

Conversation

@rlorenzo
Copy link
Copy Markdown
Contributor

  • Raise dotnet build maxBuffer to 10 MB; full warning output was overflowing the 1 MB execFileSync default and surfacing as build failures instead of the real result.
  • Purge stale static-web-asset caches in web/obj on cache clear so Vite bundle-hash changes do not produce "asset can not be found" errors.
  • Drop deprecated baseUrl from VueApp/tsconfig.json (TS resolves paths relative to tsconfig.json without it).

- Raise dotnet build maxBuffer to 10 MB; full warning output was
  overflowing the 1 MB execFileSync default and surfacing as build
  failures instead of the real result.
- Purge stale static-web-asset caches in web/obj on cache clear so
  Vite bundle-hash changes do not produce "asset can not be found"
  errors.
- Drop deprecated baseUrl from VueApp/tsconfig.json (TS resolves
  paths relative to tsconfig.json without it).
@codecov-commenter
Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.97%. Comparing base (5949e52) to head (3954b48).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   42.96%   42.97%   +0.01%     
==========================================
  Files         877      878       +1     
  Lines       51468    51483      +15     
  Branches     4802     4807       +5     
==========================================
+ Hits        22113    22125      +12     
- Misses      28831    28832       +1     
- Partials      524      526       +2     
Flag Coverage Δ
backend 43.04% <ø> (ø)
frontend 41.58% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlorenzo
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 53e36f97-386b-44cc-93c3-ebe4aa175656

📥 Commits

Reviewing files that changed from the base of the PR and between 987d173 and 3954b48.

📒 Files selected for processing (3)
  • VueApp/tsconfig.json
  • scripts/build-dotnet.js
  • scripts/lib/build-cache.js
💤 Files with no reviewable changes (1)
  • VueApp/tsconfig.json

📝 Walkthrough

Walkthrough

Three independent build configuration updates: TypeScript configuration removes baseUrl setting, build-dotnet script increases output buffer to 10MB to prevent truncation on verbose builds, and build-cache adds static web asset cleanup to prevent stale state from causing runtime errors.

Changes

Build Configuration and Cache Management

Layer / File(s) Summary
TypeScript baseUrl removal
VueApp/tsconfig.json
baseUrl setting removed from compilerOptions; @/* path alias mapping to ./src/* remains intact.
Build output buffering
scripts/build-dotnet.js
MAX_BUILD_OUTPUT constant defined (~10MB) and passed to execFileSync as maxBuffer for dotnet build invocation to prevent output truncation on verbose builds.
Static web asset cache cleanup
scripts/lib/build-cache.js
New clearStaticWebAssetCache() helper removes staticwebassets* and .dswa.cache.json entries from obj directories; integrated into full clearBuildCache() for web/obj to prevent stale artifacts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • bsedwards
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: hardening dotnet build scripts and removing deprecated baseUrl from tsconfig.json.
Description check ✅ Passed The description clearly relates to the changeset, detailing the three main modifications: maxBuffer increase, static-web-asset cache purge, and baseUrl removal.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/build-hardening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rlorenzo rlorenzo merged commit ead4375 into main May 21, 2026
12 checks passed
@rlorenzo rlorenzo deleted the chore/build-hardening branch May 21, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants