Fix safeeval subprocess call invalid unit test on some platforms#555
Merged
jonasbardino merged 1 commit intoMay 26, 2026
Conversation
…ts the `-h` argument so we need to use a more exotic value to test invalid calls.
jonasbardino
added
the
test-only
jonasbardino
added
the
test-only
albu-diku
approved these changes
May 26, 2026
Contributor
albu-diku
left a comment
albu-diku
left a comment
There was a problem hiding this comment.
This looks alright in terms of something minimal that addresses the issue in the immediate.
jonasbardino
deleted the
fix/safeeval-subprocess-call-invalid-unit-test-when-pwd-supports-help-arg
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms like Ubuntu 26.04 the
pwdcommand actually supports the-hargument, so we need to use a more exotic value to test invalid calls. Otherwisemake unittestfails intest_subprocess_call_invalid.