ICU-23385 Current implementation of dangi does not properly reflects the real-world usage of dangi#3957
Draft
Alex4386 wants to merge 1 commit into
Draft
ICU-23385 Current implementation of dangi does not properly reflects the real-world usage of dangi#3957Alex4386 wants to merge 1 commit into
dangi does not properly reflects the real-world usage of dangi#3957Alex4386 wants to merge 1 commit into
Conversation
…s the real-world usage of `dangi` Implemented cutover triggered by Gabo revision, which migrated from `ChineseCalendar` to `GregorianCalendar` It would be better that hybrid variant of the Calendar (such as SwitchoverCalendar) would exist, but It doesn't at the moment, since most of the years `DangiCalendar` were using `ChineseCalendar` (a.k.a. LunarCalendar, although this is also applied to pre-Meiji restoration `JapaneseCalendar` too), We switchover to `GregorianCalendar` after cutover conditions are met.
Member
|
Please see discussion and research in tc39/proposal-temporal#3308. It's not clear this PR is the solution we want. |
Author
Followed up, marking as draft for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist