Skip to content

ICU-23371 Use weak reference for the values in the stvStringPool cache#3984

Merged
markusicu merged 1 commit into
unicode-org:mainfrom
gvictor:ICU-23371-stvStringPool-weakref
May 22, 2026
Merged

ICU-23371 Use weak reference for the values in the stvStringPool cache#3984
markusicu merged 1 commit into
unicode-org:mainfrom
gvictor:ICU-23371-stvStringPool-weakref

Conversation

@gvictor
Copy link
Copy Markdown
Collaborator

@gvictor gvictor commented May 14, 2026 •
edited
Loading

To fix a memory leak due to the strong reference from the value to the key.

Checklist

  • Required: Issue filed: ICU-23371
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@markusicu markusicu self-requested a review May 14, 2026 16:21
yumaoka
yumaoka previously approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yumaoka yumaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

markusicu
markusicu reviewed May 15, 2026
View reviewed changes
Comment thread icu4j/main/translit/src/main/java/com/ibm/icu/text/TransliteratorRegistry.java Outdated
Comment thread icu4j/main/translit/src/main/java/com/ibm/icu/text/TransliteratorRegistry.java Outdated
@gvictor gvictor force-pushed the ICU-23371-stvStringPool-weakref branch from 84d3388 to b1853cf Compare May 22, 2026 15:10
@jira-pull-request-webhook
Copy link
Copy Markdown

jira-pull-request-webhook Bot commented May 22, 2026

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@gvictor gvictor requested a review from markusicu May 22, 2026 15:11
markusicu
markusicu approved these changes May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@markusicu markusicu merged commit 177fbc9 into unicode-org:main May 22, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markusicu markusicu markusicu approved these changes

@yumaoka yumaoka yumaoka left review comments

Assignees

@yumaoka yumaoka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvictor @yumaoka @markusicu