fix(scripts): preserve vendor method receivers by harlan-zw · Pull Request #907 · unjs/unhead

harlan-zw · 2026-07-23T13:13:48Z

🔗 Linked issue

No linked issue. Found through Sentry issue NUXTSEO-SITE-17.

❓ Type of change

📚 Description

Forwarded vendor methods received the proxy as this, which broke native receiver checks in Firefox. Method wrappers now call their owning raw object and cache nested proxies while retaining the existing void return contract.

coderabbitai · 2026-07-23T13:15:25Z

📝 Walkthrough

Walkthrough

createForwardingProxy now uses cached recursive proxies and owner-specific method wrappers. Forwarded methods preserve their receiver through Reflect.apply, and a unit test covers nested vendor method invocation.

Changes

Forwarding proxy behavior

Layer / File(s)	Summary
Cached method wrapping `packages/unhead/src/scripts/proxy.ts`	Adds method typing and per-owner `WeakMap` caches for method proxy reuse.
Recursive proxy integration `packages/unhead/src/scripts/proxy.ts`, `packages/unhead/test/unit/scripts/proxy.test.ts`	Recursively proxies nested objects, forwards property operations, and tests receiver preservation for nested methods.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant createProxy
  participant createMethodProxy
  participant NestedVendorObject
  Caller->>createProxy: Access nested vendor method
  createProxy->>createMethodProxy: Wrap method for its owner
  Caller->>createMethodProxy: Invoke forwarded method
  createMethodProxy->>NestedVendorObject: Reflect.apply(method, owner)
  NestedVendorObject-->>createMethodProxy: Execute with correct this

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main bug fix: preserving vendor method receivers in scripts.
Description check	✅ Passed	The description fills the required linked issue, change type, and detailed description sections.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/script-proxy-receivers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-23T13:17:19Z

📦 Bundle Size

⚠️ 3 bundles grew · net +0.4 kB gz

Bundle	Gzipped	Δ
Client (Full)	9.5 kB → 9.6 kB	🔴 +0.1 kB (+1.1%)
Vue Client (Full)	10.5 kB → 10.7 kB	🔴 +0.1 kB (+1.2%)
React Client (Full)	10.6 kB → 10.7 kB	🔴 +0.1 kB (+1.1%)

All bundles (14)

Bundle	Gzipped	Brotli	Raw
Core
Client (Minimal)	5.4 kB	4.9 kB	13.6 kB	✅
Client (Full)	9.6 kB	8.7 kB	25.2 kB	🔴
Client (Self-Contained)	5.7 kB	5.1 kB	14.3 kB	✅
Server (Minimal)	4.9 kB	4.4 kB	12.3 kB	✅
Server (Self-Contained)	5.2 kB	4.7 kB	13 kB	✅
Vue
Vue Client (Minimal)	5.9 kB	5.3 kB	14.6 kB	✅
Vue Client (Full)	10.7 kB	9.7 kB	28 kB	🔴
Vue Server (Minimal)	5.4 kB	4.9 kB	13.4 kB	✅
React
React Client (Minimal)	5.8 kB	5.3 kB	14.7 kB	✅
React Client (Full)	10.7 kB	9.8 kB	28.4 kB	🔴
React Server (Minimal)	5.2 kB	4.7 kB	13 kB	✅
Schema.org
Schema.org (Minimal)	10.1 kB	9.2 kB	28 kB	✅
Schema.org Imports	0.1 kB	0.1 kB	0.1 kB	✅
Schema.org Vue Meta	0.4 kB	0.3 kB	0.8 kB	✅

📦 Runtime Dependencies

✅ No runtime dependency changes

All packages (10)

Package	External deps	Install size	Largest dependency	Skipped optional
@unhead/angular	10	773.6 kB	@jridgewell/trace-mapping 146.7 kB	0
@unhead/bundler	18	5.6 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
@unhead/cli	22	5.7 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
@unhead/eslint-plugin	9	683.2 kB	@jridgewell/trace-mapping 146.7 kB	0
@unhead/react	19	5.6 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
@unhead/schema-org	9	683.2 kB	@jridgewell/trace-mapping 146.7 kB	0
@unhead/solid-js	19	5.6 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
@unhead/svelte	19	5.6 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
@unhead/vue	19	5.6 MB	@oxc-parser/binding-linux-arm64-gnu 2.2 MB	19
unhead	9	683.2 kB	@jridgewell/trace-mapping 146.7 kB	0

Skipped optional dependencies (114)

@unhead/bundler: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc
@unhead/cli: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc
@unhead/react: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc
@unhead/solid-js: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc
@unhead/svelte: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc
@unhead/vue: oxc-parser -> @oxc-parser/binding-android-arm-eabi, oxc-parser -> @oxc-parser/binding-android-arm64, oxc-parser -> @oxc-parser/binding-darwin-arm64, oxc-parser -> @oxc-parser/binding-darwin-x64, oxc-parser -> @oxc-parser/binding-freebsd-x64, oxc-parser -> @oxc-parser/binding-linux-arm-gnueabihf, oxc-parser -> @oxc-parser/binding-linux-arm-musleabihf, oxc-parser -> @oxc-parser/binding-linux-arm64-musl, oxc-parser -> @oxc-parser/binding-linux-ppc64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-gnu, oxc-parser -> @oxc-parser/binding-linux-riscv64-musl, oxc-parser -> @oxc-parser/binding-linux-s390x-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-gnu, oxc-parser -> @oxc-parser/binding-linux-x64-musl, oxc-parser -> @oxc-parser/binding-openharmony-arm64, oxc-parser -> @oxc-parser/binding-wasm32-wasi, oxc-parser -> @oxc-parser/binding-win32-arm64-msvc, oxc-parser -> @oxc-parser/binding-win32-ia32-msvc, oxc-parser -> @oxc-parser/binding-win32-x64-msvc

_{Production dependencies only. Peer dependencies and Unhead workspace packages are excluded. Skipped optional dependencies are unavailable on the CI platform.}

⚡ Performance (directional)

✅ No significant change (within CI noise)

All benchmarks (14)

Benchmark	PR	Δ	RME
SSR render (CPU)	0.363 ms	~ noise	±9.7%
SSR render (wall)	0.262 ms	~ noise	±4.8%
SSR allocated / render	243.1 KiB	~ noise	±4.8%
Schema.org cached render (CPU)	0.344 ms	~ noise	±6.8%
Schema.org cached render (wall)	0.244 ms	~ noise	±3.1%
Schema.org cached allocated / render	133.4 KiB	~ noise	±1.4%
Streaming wrapStream drain (CPU)	0.244 ms	~ noise	±5.0%
Streaming wrapStream drain (wall)	0.152 ms	~ noise	±4.8%
Streaming allocated / drain	149.8 KiB	~ noise	±0.3%
Streaming suspense chunk (CPU)	0.012 ms	~ noise	±6.4%
Streaming allocated / suspense chunk	5.1 KiB	~ noise	±0.4%
CSR DOM mutations / nav	38	~ noise	—
CSR re-render (CPU)	0.847 ms	~ noise	±5.2%
CSR re-render (wall)	0.481 ms	~ noise	±2.2%

_{Baseline: main @ d9b3d2a · 2026-07-26 · gzipped is the headline size metric · perf is directional (shared-runner, gated)}

harlan-zw · 2026-07-27T06:26:34Z

🤖 Harlan Agent Kit automated review

This was generated and posted by a robot, not Harlan's personal review.

PASS · 95/100 confidence

Reviewed bf381159 against main@d9b3d2a6
Base current; GitHub reports no conflicts
PR title and body match the project template; review threads are resolved
Adversarial review found no remaining material code issue
Complete diff reviewed; required CI passed 9/9; confidence includes limited local execution

Human merge decision still required.

fix(scripts): preserve vendor method receivers

0830e5f

harlan-zw mentioned this pull request Jul 23, 2026

fix: preserve vendor API method receivers nuxt/scripts#843

Open

4 tasks

harlan-zw added v3 Targets Unhead v3 or the main branch bug Something isn't working scripts Script loading and lifecycle APIs labels Jul 24, 2026

Merge branch 'main' into fix/script-proxy-receivers

bf38115

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(scripts): preserve vendor method receivers - #907

fix(scripts): preserve vendor method receivers#907
harlan-zw wants to merge 2 commits into
mainfrom
fix/script-proxy-receivers

harlan-zw commented Jul 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

harlan-zw commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

harlan-zw commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

❓ Type of change

📚 Description

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size

📦 Runtime Dependencies

⚡ Performance (directional)

Uh oh!

harlan-zw commented Jul 27, 2026

🤖 Harlan Agent Kit automated review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

harlan-zw commented Jul 23, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

github-actions Bot commented Jul 23, 2026 •

edited

Loading