Add 1.12.0-sarek-dyasync to DXWrapper in manifest.json#1569
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new DXVK build entry to the manifest so it can be selected/downloaded as an available DXVK option.
Changes:
- Added a new DXVK manifest entry for version
1.12.0-sarek-dyasync - Points the new entry to the
downloads.gamenative.apphosted.wcpartifact
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughTop-level manifest ChangesDXVK version manifest update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@manifest.json`:
- Around line 2-3: Update the manifest "version" field from 1 to 2 in the
manifest.json file: locate the "version" key (currently "version": 1) and change
its value to 2 so the manifest reflects the intended version bump; leave other
fields like "updatedAt" unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/assets/dxwrapper_download.json`:
- Around line 40-44: The manifest entry uses id "dxvk-1.12.0-sarek" and a .wcp
name/url that don't match the runtime component contract which expects
componentId to map exactly to downloads at dxwrapper/<componentId>.tzst; update
the entry so id, name and url are consistent with the runtime lookup (for
example set id to "dxvk-1.12.0-sarek-dyasync", name to
"dxvk-1.12.0-sarek-dyasync.tzst", and url to
"https://downloads.gamenative.app/dxwrapper/dxvk-1.12.0-sarek-dyasync.tzst") or
alternatively adjust the downloader logic to accept the current .wcp naming;
make sure the id string used here matches the componentId used by the
downloader.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4dba531a-1bb1-4a40-b81f-b87e2025fcc8
📒 Files selected for processing (2)
app/src/main/assets/dxwrapper_download.jsonmanifest.json
🚧 Files skipped from review as they are similar to previous changes (1)
- manifest.json
| { | ||
| "id": "dxvk-1.12.0-sarek", | ||
| "name": "dxvk-1.12.0-sarek.wcp", | ||
| "url": "https://downloads.gamenative.app/dxwrapper/dxvk-sarek-dyasync-1.12.0.wcp" | ||
| }, |
There was a problem hiding this comment.
Component contract is inconsistent with runtime lookup/download format.
This entry won’t reliably resolve at runtime: componentId is matched by exact id, and downloads are forced to dxwrapper/<componentId>.tzst, but this record uses dxvk-1.12.0-sarek plus .wcp metadata while the PR objective introduces 1.12.0-sarek-dyasync. Align id and artifact naming with the .tzst component contract (or update downloader logic in the paired change).
Suggested manifest-side alignment
{
- "id": "dxvk-1.12.0-sarek",
- "name": "dxvk-1.12.0-sarek.wcp",
- "url": "https://downloads.gamenative.app/dxwrapper/dxvk-sarek-dyasync-1.12.0.wcp"
+ "id": "dxvk-1.12.0-sarek-dyasync",
+ "name": "dxvk-1.12.0-sarek-dyasync.tzst",
+ "url": "https://downloads.gamenative.app/dxwrapper/dxvk-1.12.0-sarek-dyasync.tzst"
},🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/src/main/assets/dxwrapper_download.json` around lines 40 - 44, The
manifest entry uses id "dxvk-1.12.0-sarek" and a .wcp name/url that don't match
the runtime component contract which expects componentId to map exactly to
downloads at dxwrapper/<componentId>.tzst; update the entry so id, name and url
are consistent with the runtime lookup (for example set id to
"dxvk-1.12.0-sarek-dyasync", name to "dxvk-1.12.0-sarek-dyasync.tzst", and url
to "https://downloads.gamenative.app/dxwrapper/dxvk-1.12.0-sarek-dyasync.tzst")
or alternatively adjust the downloader logic to accept the current .wcp naming;
make sure the id string used here matches the componentId used by the
downloader.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/assets/dxwrapper_download.json">
<violation number="1" location="app/src/main/assets/dxwrapper_download.json:41">
P2: New DXWrapper entry uses ID `dxvk-1.12.0-sarek` for a `sarek-dyasync` artifact, creating a metadata mismatch</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "url": "https://downloads.gamenative.app/dxwrapper/dxvk-1.11.1-sarek.tzst" | ||
| }, | ||
| { | ||
| "id": "dxvk-1.12.0-sarek", |
There was a problem hiding this comment.
P2: New DXWrapper entry uses ID dxvk-1.12.0-sarek for a sarek-dyasync artifact, creating a metadata mismatch
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/assets/dxwrapper_download.json, line 41:
<comment>New DXWrapper entry uses ID `dxvk-1.12.0-sarek` for a `sarek-dyasync` artifact, creating a metadata mismatch</comment>
<file context>
@@ -37,6 +37,11 @@
"url": "https://downloads.gamenative.app/dxwrapper/dxvk-1.11.1-sarek.tzst"
},
+ {
+ "id": "dxvk-1.12.0-sarek",
+ "name": "dxvk-1.12.0-sarek.wcp",
+ "url": "https://downloads.gamenative.app/dxwrapper/dxvk-sarek-dyasync-1.12.0.wcp"
</file context>
|
Do we also need to add: DXVK_DISABLE_DYASYNC=0 as per their instructions on the repo? |
Hi @phobos665 We can add it on the Suggestion Presets. if needed to be used, they can quickly pull it up. I tested Brotato with this Sarek and didn't need to add it, as 0 or 1. Currently the PR is parked because of the package naming failing the tests. Utkarsh is going to try to change the package reported name inside the file (currently in gamenative cloud server) so that it passes. |
Description
Add 1.12.0-sarek-dyasync to manifest.json
Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Added DXVK 1.12.0-sarek-dyasync to the DXWrapper downloads manifest so users can install the bionic
.wcpbuild.New entry: id
dxvk-1.12.0-sarek, name "dxvk-1.12.0-sarek.wcp", URL https://downloads.gamenative.app/dxwrapper/dxvk-sarek-dyasync-1.12.0.wcpWritten for commit 791d6ae. Summary will update on new commits.
Summary by CodeRabbit