fix: strip unknown internal attributes during migration#200
Open
deepshekhardas wants to merge 1 commit into
Open
fix: strip unknown internal attributes during migration#200deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
Source (Appwrite.php): add to the list of stripped internal fields when exporting records, preventing it from leaking into row data. Destination (Appwrite.php): replace blind skip of all $-prefixed fields with an explicit allowlist of known internal attributes (, , , , , ). Unknown $-prefixed fields (e.g. from older sources, , , ) are now stripped before document creation, preventing Structure validator rejections. Fixes appwrite/appwrite#10265
Contributor
Greptile SummaryThis PR strips Appwrite internal row metadata during migration. The main changes are:
Confidence Score: 5/5The migration changes are narrowly scoped and safe to merge. No correctness issues were identified in the changed source and destination filtering logic.
What T-Rex did
Reviews (1): Last reviewed commit: "fix: strip unknown internal attributes d..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes internal attribute leakage during Appwrite-to-Appwrite migration, which causes Invalid document structure: Unknown attribute: "" errors.
Changes
Source (Appwrite.php)
Destination (Appwrite.php)
Related Issues