Migrate to utopia-php/di 0.3#9
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis pull request updates system requirements in README.md from PHP 8.0 to PHP 8.2 and updates composer.json to require PHP >=8.2 and bump utopia-php/di from 0.1.* to 0.3.*. In src/Servers/Base.php the prepare/validation flow was refactored to create and use a dedicated local scope container for parameter injection, validation, and storage instead of mutating the passed context; callable validators are registered and retrieved via keys on that scope and prepare now returns the scope. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 30: Replace the generic project name in the compatibility line: change
"Utopia Framework requires PHP 8.2 or later." to explicitly reference this
package (e.g., "utopia-php/servers requires PHP 8.2 or later.") so the README
uses the package/library name instead of "Utopia Framework" (update the sentence
that currently contains "Utopia Framework requires PHP 8.2 or later" in
README.md).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: efc6be10-d562-4901-858c-08c1724b5227
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
README.mdcomposer.jsonsrc/Servers/Base.php
268b51c to
c7becb1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Servers/Base.php`:
- Line 269: Add a guarded internal prefix and reject param names that collide
with it: declare a constant (e.g., INTERNAL_VALIDATOR_PREFIX = '_validator:') in
the class and, at the point where params are registered (the code calling
$scope->set($key, fn () => $value, [])), validate the provided $key and
throw/return an error if it begins with that prefix; then continue to store
validators under the reserved prefixed id (use $validatorKey =
self::INTERNAL_VALIDATOR_PREFIX . $key where validators are set) so that param
keys and validator keys cannot silently overwrite each other via
Container::set().
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4454fafc-9fff-448a-b006-a7f21364828e
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
README.mdcomposer.jsonsrc/Servers/Base.php
🚧 Files skipped from review as they are similar to previous changes (2)
- README.md
- composer.json
Intra-utopia requires move from X.Y.* pins to ^X.Y across cli, http, platform, queue and servers (client and pools already used carets). For 0.x siblings the range is equivalent today, but the style is uniform and minors flow through automatically once packages reach 1.0. servers' broad 'validators 0.*' narrows to ^0.2, matching the released line. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Summary
utopia-php/dito0.3.*and align the package PHP requirement to>=8.2Baseaway from the removedDependency/inject()API to the new scoped container APIcomposer.lockfor the dependency and platform changesTesting
vendor/bin/phpunitvendor/bin/phpstan analyseSummary by CodeRabbit
Documentation
Dependencies
Refactor