Skip to content

fix: include status code and response body in GitHub token error#113

Merged
HarshMN2345 merged 2 commits into
mainfrom
fix/github-token-error-details
Jun 16, 2026
Merged

fix: include status code and response body in GitHub token error#113
HarshMN2345 merged 2 commits into
mainfrom
fix/github-token-error-details

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

  • Updates the GitHub App installation token error path in src/VCS/Adapter/Git/GitHub.php.
  • Adds the HTTP status code to the token retrieval failure message.
  • Limits response-body diagnostics to the allow-listed message and documentation_url fields.

Confidence Score: 5/5

The change is narrowly scoped to diagnostic text for GitHub installation token failures and does not alter the success path.

No code issues were identified in the modified error handling path, and the response-body exposure is constrained to explicit allow-listed fields.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the test suite focused on the GitHub authentication path to verify access token retrieval behavior.
  • Captured two log artifacts representing the base and head states of the GitHub access token retrieval flow.
  • Compared the base and head outputs to note how the head commit adds HTTP status and a Bad credentials message to the exception.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "fix: only expose safe fields from GitHub..." | Re-trigger Greptile

Comment thread src/VCS/Adapter/Git/GitHub.php
Comment thread src/VCS/Adapter/Git/GitHub.php
@HarshMN2345 HarshMN2345 merged commit 598cbd2 into main Jun 16, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants