parser: reject reserved keywords in qualified identifiers#52
Conversation
Validate namespace and literal parts of ns::name against gawk's reserved keyword list when building identifiers, including @namespace directives. Closes: uutils#37
There was a problem hiding this comment.
This is nice, but scales very poorly. As I mentioned in the Discord, I have been doing some testing with the other option I had mentioned (separating the path as a different token), and it integrates a lot better with Logos, resulting in a negative diff; I should be able to get it polished by Friday. However, the tests are great and we can keep them. Would you be okay just keeping the tests, so we can merge this after I push? Ty!
@Alonely0 Thank you for the review. I am glad to hear that the optimization is nearing completion, and I am happy to keep only these test cases. |
2 participants
Validate namespace and literal parts of ns::name against gawk's reserved keyword list when building identifiers, including @namespace directives.
Closes: #37