Skip to content

nice: add newline to warning message#12929

Merged
cakebaker merged 8 commits into
uutils:mainfrom
Devel08:fix-issue-12927
Jun 19, 2026
Merged

nice: add newline to warning message#12929
cakebaker merged 8 commits into
uutils:mainfrom
Devel08:fix-issue-12927

Conversation

@Devel08

@Devel08 Devel08 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This pr closes #12927. Is test required? I don't think that can regress in future

@oech3

oech3 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Is test required?

We can change existing tests to use .stdout_is() after stripping errno instead.

@Devel08

Devel08 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Ahh, it succeeds with stderr, alright ... Ready for review

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)

@Devel08

Devel08 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker it seems that there is already test_negative_adjustment, should I remove my test_nice_adj_negative and edit test_negative_adjustment to use stdout_is with newline?

@cakebaker

cakebaker commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I would "merge" the two tests into one: keep your code as it is cleaner and take the comment from the other test.

@sylvestre

Copy link
Copy Markdown
Contributor

needs to be rebase
and please move the tests where it was in the file

@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.12%

⚡ 1 improved benchmark
✅ 322 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_all_wide_tree[(5000, 500)] 16.7 ms 16.2 ms +3.12%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Devel08:fix-issue-12927 (0d3541f) with main (de30f0a)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit 395da6a into uutils:main Jun 19, 2026
106 of 174 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nice: missing newline on nice --adj -20 true

4 participants