nice: add newline to warning message#12929
Conversation
We can change existing tests to use |
|
Ahh, it succeeds with stderr, alright ... Ready for review |
|
GNU testsuite comparison: |
|
@cakebaker it seems that there is already test_negative_adjustment, should I remove my test_nice_adj_negative and edit test_negative_adjustment to use stdout_is with newline? |
|
I would "merge" the two tests into one: keep your code as it is cleaner and take the comment from the other test. |
|
needs to be rebase |
Merging this PR will improve performance by 3.12%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
0d3541f to
ad75497
Compare
|
Thanks! |
This pr closes #12927. Is test required? I don't think that can regress in future