Skip to content

Mo 229 sept 26 part 3 FE class based models#2227

Merged
MuhammadKhalilzadeh merged 10 commits intodevelopfrom
mo-229-sept-26-fe-class-based-models
Sep 26, 2025
Merged

Mo 229 sept 26 part 3 FE class based models#2227
MuhammadKhalilzadeh merged 10 commits intodevelopfrom
mo-229-sept-26-fe-class-based-models

Conversation

@MuhammadKhalilzadeh
Copy link
Copy Markdown
Collaborator

part 3 FE class based models

part 3 FE class based models: ISO24001 entities

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I have avoided using hardcoded values to ensure scalability and maintain consistency across the application.
  • I have ensured that font sizes, color choices, and other UI elements are referenced from the theme.
  • My pull request is focused and addresses a single, specific feature.

@MuhammadKhalilzadeh MuhammadKhalilzadeh self-assigned this Sep 26, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates import paths in three Common model files and introduces multiple new TypeScript model classes for ISO-42001, including structure models, annex category and subclause models with status and metadata fields, and two risk association models with simple factory constructors.

Changes

Cohort / File(s) Summary
Common models: import path adjustments
Clients/src/domain/models/Common/modelInventory/modelInventory.model.ts, Clients/src/domain/models/Common/modelRisk/modelRisk.model.ts, Clients/src/domain/models/Common/task/task.model.ts
Updated relative import paths to ../../../interfaces; no functional changes.
ISO-42001 structure models
Clients/src/domain/models/ISO-42001/annexStructISO42001/annexStructISO42001.model.ts, Clients/src/domain/models/ISO-42001/clauseStructISO42001/clauseStructISO42001.model.ts, Clients/src/domain/models/ISO-42001/subClauseStructISO42001/subClauseStructISO42001.model.ts
Added model classes for annex, clause, and subclause structures with ids, titles, ordering, and related metadata; constructors and static factory methods included.
ISO-42001 annex category and subclause models
Clients/src/domain/models/ISO-42001/annexCategoryISO42001/annexCategoryISO42001.model.ts, Clients/src/domain/models/ISO-42001/subClauseISO42001/subClauseISO42001.model.ts
Added models capturing implementation details, evidence links, ownership, dates, status, and related ids; each includes constructor and static factory.
ISO-42001 risk association models
Clients/src/domain/models/ISO-42001/annexCategoryISO42001RIsk/annexCategoryISO42001RIsk.model.ts, Clients/src/domain/models/ISO-42001/subClauseISO42001Risk/subClauseISO42001Risk.model.ts
Added simple link models mapping annex category/subclause to project risks with constructors and static factories.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

A rabbit taps code on the ISO breeze,
New models sprout like data trees.
Paths hop higher, imports align,
Clauses, annex, risks in line.
With factory paws and fields so neat,
This garden of types feels quite complete. 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mo-229-sept-26-fe-class-based-models

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46b3bf9 and 844e989.

📒 Files selected for processing (11)
  • Clients/src/domain/models/Common/modelInventory/modelInventory.model.ts (1 hunks)
  • Clients/src/domain/models/Common/modelRisk/modelRisk.model.ts (1 hunks)
  • Clients/src/domain/models/Common/task/task.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/annexCategoryISO42001/annexCategoryISO42001.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/annexCategoryISO42001RIsk/annexCategoryISO42001RIsk.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/annexCategoryStructISO42001/annexCategoryStructISO42001.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/annexStructISO42001/annexStructISO42001.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/clauseStructISO42001/clauseStructISO42001.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/subClauseISO42001/subClauseISO42001.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/subClauseISO42001Risk/subClauseISO42001Risk.model.ts (1 hunks)
  • Clients/src/domain/models/ISO-42001/subClauseStructISO42001/subClauseStructISO42001.model.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MuhammadKhalilzadeh MuhammadKhalilzadeh added enhancement New feature or request frontend Frontend related tasks/issues labels Sep 26, 2025
@MuhammadKhalilzadeh MuhammadKhalilzadeh added this to the 1.5 milestone Sep 26, 2025
@MuhammadKhalilzadeh MuhammadKhalilzadeh merged commit 3807876 into develop Sep 26, 2025
1 of 2 checks passed
@MuhammadKhalilzadeh MuhammadKhalilzadeh deleted the mo-229-sept-26-fe-class-based-models branch September 26, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Frontend related tasks/issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant