Ks 027 sep 29 figma icons 2047 by solan117 · Pull Request #2243 · verifywise-ai/verifywise

solan117 · 2025-09-29T05:48:02Z

Describe your changes

Changed MUI icons to SVG Icons for contentcopy, questionmark, checkcircle, refresh, expandmore, expandless, groups, viewtoggles.

Write your issue number after "Fixes "

Fixes #2047

Please ensure all items are checked off before requesting a review:

I deployed the code locally.
I have performed a self-review of my code.
I have included the issue # in the PR.
I have labelled the PR correctly.
The issue I am working on is assigned to me.
I have avoided using hardcoded values to ensure scalability and maintain consistency across the application.
I have ensured that font sizes, color choices, and other UI elements are referenced from the theme.
My pull request is focused and addresses a single, specific feature.
If there are UI changes, I have attached a screenshot or video to this PR.

…pdate styles - Replaced `@mui/icons-material/ContentCopy` with `contentCopy.svg`. - Updated imports and adjusted icon styles for consistency. chore(gitignore): add `.rate-limit-state.json` to ignored files list

- Replaced `@mui/icons-material/QuestionMark` with `questionMark.svg`. - Updated import path for the new SVG.

…G `check-circle-green` - Replaced `@mui/icons-material/CheckCircleOutline` with `check-circle-green.svg`. - Updated imports and adjusted styles for consistent integration of the new SVG icon.

…eck-circle-green` and update styles - Replaced `@mui/icons-material/CheckCircleOutline` with `check-circle-green.svg`. - Updated imports and adjusted icon styles for consistent sizing across components.

… icon - Replaced `@mui/icons-material/Refresh` with `refresh.svg`. - Updated imports to use the custom SVG icon.

…es` with custom SVG icons - Replaced `@mui/icons-material` icons (`FilterList`, `Clear`, `ExpandMore`, `ExpandLess`) with custom SVGs (`filter.svg`, `clear.svg`, `expand-down.svg`, `expand-up.svg`). - Updated imports and adjusted styles for consistent integration of custom SVG icons.

…ge` with custom SVGs - Replaced `QuestionMarkIcon` with `questionMark.svg` in `Guider`. - Replaced `ArrowBackIcon` with `left-arrow-long.svg` in `FairnessResultsPage`. - Updated imports for proper integration of custom SVG icons.

- Replaced `@mui/icons-material/Groups` with `group.svg`. - Updated import path for the new SVG icon.

- Replaced `ViewModuleIcon` with `viewModule.svg`. - Replaced `TableRowsIcon` with `tableRows.svg`. - Updated imports to integrate custom SVG icons.

coderabbitai · 2025-09-29T05:48:10Z

Walkthrough

Replaces multiple @mui/icons-material imports with local SVG ReactComponent icons across client components and adjusts icon styling from MUI sx props to inline styles; adds .rate-limit-state.json to Servers/.gitignore. No changes to component logic, control flow, or public APIs.

Changes

Cohort / File(s)	Summary
Client icon migration to local SVGs `Clients/src/presentation/components/Alert/AlertBody.tsx`, `Clients/src/presentation/components/Helpers/Guider/index.tsx`, `Clients/src/presentation/components/RiskVisualization/RiskCategories.tsx`, `Clients/src/presentation/components/RiskVisualization/RiskFilters.tsx`, `Clients/src/presentation/components/ViewToggle/index.tsx`, `Clients/src/presentation/pages/AITrustCentrePublic/Overview/index.tsx`, `Clients/src/presentation/pages/AITrustCentrePublic/Resources/index.tsx`, `Clients/src/presentation/pages/FairnessDashboard/FairnessResultsPage.tsx`, `Clients/src/presentation/pages/SettingsPage/Team/index.tsx`, `Clients/src/presentation/pages/WatchTower/Loggings/index.tsx`	Replace `@mui/icons-material` imports with local SVGs imported as ReactComponents; adjust icon styling from MUI `sx` usage to inline `style` props (explicit width/height and color) or default SVG sizing. No behavioral, prop, or API changes.
Server gitignore update `Servers/.gitignore`	Add `.rate-limit-state.json` to ignore list and ensure trailing newline for an existing README entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Ks 023 sep 23 figma icons 2047 #2206 — Performs the same replacement of MUI icons with local SVG ReactComponents and adjusts styling across multiple client components.
Ks 022 sep 22 figma icons 2047 #2192 — Similar icon migration pattern; overlaps with client pages (e.g., FairnessResultsPage).
Ks 018 sep 18 figma icons 2047 #2165 — Same refactor pattern converting MUI icon imports to local SVG ReactComponents across client components.

Suggested reviewers

MuhammadKhalilzadeh

Poem

A little rabbit hopped through code tonight,
Swapped icons for sprites that fit just right.
No logic stirred, just pixels tuned,
A gentler UI, softly crooned.
Thump-thump—deploy beneath moonlight. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The provided title “Ks 027 sep 29 figma icons 2047” is ambiguous and includes internal codes and a date rather than clearly describing the main change of replacing MUI icons with Figma SVGs across the application, so it does not convey the primary update to reviewers.	Please rename the title to a concise, descriptive sentence such as “Replace MUI icons with Figma SVG icons across the dashboard” to clearly reflect the core change.
Out of Scope Changes Check	⚠️ Warning	The pull request includes updates to the server’s .gitignore file (adding .rate-limit-state.json and adjusting a README entry) which are unrelated to the icon replacement objectives defined in issue #2047.	Remove the .gitignore modifications from this PR or split them into a separate change so that only the icon-related updates remain in this pull request.
Description Check	⚠️ Warning	The description follows the repository template by describing the change and including “Fixes #2047” and the checklist, but the final checkbox for attaching a screenshot or video of the UI changes is left unchecked despite icon updates affecting the user interface.	Attach a screenshot or short video demonstrating the updated icons in context and check off the last item in the template to fully complete the pull request description.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues Check	✅ Passed	The changes replace every MUI icon import across components and pages—such as content copy, question mark, expand/collapse, filter, clear, view toggle, check circle, arrow back, groups, and refresh—with corresponding local Figma SVG ReactComponents, preserving usage and meeting the objective to align iconography with the Figma design system.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ks-027-Sep-29-figma-icons-2047

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57207e6 and 921700d.

📒 Files selected for processing (1)

Clients/src/presentation/components/Alert/AlertBody.tsx (2 hunks)

🔇 Additional comments (1)

Clients/src/presentation/components/Alert/AlertBody.tsx (1)

63-65: Thanks for fixing the copy icon sizing.

Switching to explicit "13px" dimensions ensures the SVG renders at the intended size. Nicely done.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 631f8bf and 57207e6.

⛔ Files ignored due to path filters (6)

Clients/src/presentation/assets/icons/contentCopy.svg is excluded by !**/*.svg
Clients/src/presentation/assets/icons/group.svg is excluded by !**/*.svg
Clients/src/presentation/assets/icons/questionMark.svg is excluded by !**/*.svg
Clients/src/presentation/assets/icons/refresh.svg is excluded by !**/*.svg
Clients/src/presentation/assets/icons/tableRows.svg is excluded by !**/*.svg
Clients/src/presentation/assets/icons/viewModule.svg is excluded by !**/*.svg

📒 Files selected for processing (11)

Clients/src/presentation/components/Alert/AlertBody.tsx (2 hunks)
Clients/src/presentation/components/Helpers/Guider/index.tsx (1 hunks)
Clients/src/presentation/components/RiskVisualization/RiskCategories.tsx (2 hunks)
Clients/src/presentation/components/RiskVisualization/RiskFilters.tsx (2 hunks)
Clients/src/presentation/components/ViewToggle/index.tsx (2 hunks)
Clients/src/presentation/pages/AITrustCentrePublic/Overview/index.tsx (2 hunks)
Clients/src/presentation/pages/AITrustCentrePublic/Resources/index.tsx (2 hunks)
Clients/src/presentation/pages/FairnessDashboard/FairnessResultsPage.tsx (1 hunks)
Clients/src/presentation/pages/SettingsPage/Team/index.tsx (1 hunks)
Clients/src/presentation/pages/WatchTower/Loggings/index.tsx (1 hunks)
Servers/.gitignore (1 hunks)

🔇 Additional comments (1)

Clients/src/presentation/pages/AITrustCentrePublic/Resources/index.tsx (1)

13-47: SVG swap aligns with Figma specs

Localizing the icon and pinning it to 24×24 keeps the layout consistent with the new icon system. Looks good.

solan117 added 9 commits September 29, 2025 00:34

refactor(icons): replace MUI ContentCopy icon with custom SVG and u…

4e13b68

…pdate styles - Replaced `@mui/icons-material/ContentCopy` with `contentCopy.svg`. - Updated imports and adjusted icon styles for consistency. chore(gitignore): add `.rate-limit-state.json` to ignored files list

refactor(icons): replace MUI QuestionMark icon with custom SVG

037e62c

- Replaced `@mui/icons-material/QuestionMark` with `questionMark.svg`. - Updated import path for the new SVG.

refactor(icons): replace MUI CheckCircleOutline icon with custom SV…

a80402e

…G `check-circle-green` - Replaced `@mui/icons-material/CheckCircleOutline` with `check-circle-green.svg`. - Updated imports and adjusted styles for consistent integration of the new SVG icon.

refactor(icons): replace MUI CheckCircleOutline with custom SVG `ch…

fe37b55

…eck-circle-green` and update styles - Replaced `@mui/icons-material/CheckCircleOutline` with `check-circle-green.svg`. - Updated imports and adjusted icon styles for consistent sizing across components.

refactor(icons): replace MUI Refresh icon with custom SVG refresh…

cfb174e

… icon - Replaced `@mui/icons-material/Refresh` with `refresh.svg`. - Updated imports to use the custom SVG icon.

refactor(icons): replace MUI Groups icon with custom SVG group icon

2a89c71

- Replaced `@mui/icons-material/Groups` with `group.svg`. - Updated import path for the new SVG icon.

refactor(icons): replace MUI icons in ViewToggle with custom SVGs

57207e6

- Replaced `ViewModuleIcon` with `viewModule.svg`. - Replaced `TableRowsIcon` with `tableRows.svg`. - Updated imports to integrate custom SVG icons.

solan117 added this to the 1.5 milestone Sep 29, 2025

solan117 requested a review from MuhammadKhalilzadeh September 29, 2025 05:48

solan117 self-assigned this Sep 29, 2025

solan117 added enhancement New feature or request frontend Frontend related tasks/issues labels Sep 29, 2025

coderabbitai Bot reviewed Sep 29, 2025

View reviewed changes

Comment thread Clients/src/presentation/components/Alert/AlertBody.tsx

fix(styles): correct ContentCopyIcon dimensions by adding px units

921700d

MuhammadKhalilzadeh approved these changes Sep 29, 2025

View reviewed changes

MuhammadKhalilzadeh merged commit 5d31e55 into develop Sep 29, 2025
3 checks passed

MuhammadKhalilzadeh deleted the ks-027-Sep-29-figma-icons-2047 branch September 29, 2025 16:28

coderabbitai Bot mentioned this pull request Oct 1, 2025

Ks 030 oct 01 figma icons 2047 #2285

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ks 027 sep 29 figma icons 2047#2243

Ks 027 sep 29 figma icons 2047#2243
MuhammadKhalilzadeh merged 10 commits intodevelopfrom
ks-027-Sep-29-figma-icons-2047

solan117 commented Sep 29, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

solan117 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Write your issue number after "Fixes "

Please ensure all items are checked off before requesting a review:

Uh oh!

coderabbitai Bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

solan117 commented Sep 29, 2025 •

edited

Loading

coderabbitai Bot commented Sep 29, 2025 •

edited

Loading