Merged
Conversation
Built-in plugins (like dataset-bulk-upload) register routes directly in Express and don't have remote code in the plugin marketplace. The getDataFromProviders loop was attempting to load code for all installed plugins, causing 404 errors for built-in plugins with __builtin__ sentinel paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a defensive check at the top of downloadAndLoadPlugin to throw a clear error if a built-in plugin with __builtin__ sentinel values reaches this method. Prevents cryptic 404 errors and provides an actionable message directing callers to check isBuiltinPlugin() first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… errors Replace console.error(..., error) with single-line messages that extract only error.message plus status/url for Axios errors. Prevents hundreds of lines of circular Axios error objects from flooding the backend console on plugin load failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add stubs for window.matchMedia, IntersectionObserver, ResizeObserver, and VITE_APP_API_BASE_URL that are required for MUI components to render in the jsdom test environment without errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add reusable test wrapper that provides Redux store, MemoryRouter, MUI ThemeProvider, and React Query context. Accepts optional preloadedState, store, and routerProps overrides for flexible test configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add e2e exclusion pattern to avoid Playwright tests running in Vitest. Set VITE_APP_API_BASE_URL env var for test environment. Lower coverage thresholds to 10% for initial rollout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 8 tests covering variant rendering (success, error, warning, info), toast close button visibility, and icon display per variant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 6 tests covering label rendering, checked/unchecked states, onChange handler, size prop, and disabled state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 13 tests covering text/password/url/description input types, password visibility toggle, error and helper text display, required and optional indicators, and custom width styling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 4 tests covering redirect to /login without auth token, rendering children with valid token, nested route rendering, and reloadTrigger prop propagation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 4 tests covering form field rendering (email, password), login button, forgot password link, and register link presence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add @playwright/test ^1.58.2, @axe-core/playwright ^4.11.1, and @testing-library/dom ^10.4.1 as dev dependencies. Add test:e2e, test:e2e:headed, and test:e2e:debug npm scripts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ignore test-results/, playwright-report/, blob-report/, playwright/.cache/, and e2e/.auth/ directories. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Configure sequential execution with 1 worker and 3 projects: setup (global auth), auth-tests (unauthenticated), and chromium (authenticated with stored state). Auto-starts Vite dev server on port 5173. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add global.setup.ts that performs UI-based login and saves storageState for reuse. Add auth.fixture.ts with authedPage fixture that loads stored auth state and navigates to the dashboard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 6 tests: login page rendering, unauthenticated redirect, successful login flow, invalid credentials error, forgot password navigation, and register link navigation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 9 tests verifying authenticated navigation to all major pages: dashboard, compliance tracker, risk management, model inventory, settings, vendors, AI trust center, file manager, and policies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add 3 tests covering vendor page title display, tab navigation elements, and search functionality. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add seedTestData.ts that creates a test organization and admin user (test@example.com / Test1234!) for E2E tests. Uses findOrCreate semantics for idempotent execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add unit-and-component-tests job that runs vitest with coverage and uploads coverage report as artifact. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add GitHub Actions workflow with PostgreSQL and Redis services that builds the backend, runs migrations, seeds test data, starts the server, and runs Playwright tests. Uploads HTML report on failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MuhammadKhalilzadeh
added
enhancement
gorkem-bwl
approved these changes
Feb 24, 2026
The CI workflow starts the Vite dev server before Playwright runs. With reuseExistingServer set to !process.env.CI (false in CI), Playwright tried to start a second server on port 5173 and failed. Set to true unconditionally so Playwright reuses any already-running server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright & UI Tests
Please ensure all items are checked off before requesting a review: