Skip to content

Inline validation replaced with generic hook on NewTraining#3639

Merged
Br0wnHammer merged 2 commits intodevelopfrom
feature/new-training-modal-replace-inline-validation-with-generic-hook
Mar 31, 2026
Merged

Inline validation replaced with generic hook on NewTraining#3639
Br0wnHammer merged 2 commits intodevelopfrom
feature/new-training-modal-replace-inline-validation-with-generic-hook

Conversation

@Innagl
Copy link
Copy Markdown
Contributor

@Innagl Innagl commented Mar 30, 2026

Describe your changes

A reusable generic useFormValidation hook has been integrated into the "New Training" modal, replacing the previous custom validation logic.

Write your issue number after "Fixes "

Fixes #3628

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I have avoided using hardcoded values to ensure scalability and maintain consistency across the application.
  • I have ensured that font sizes, color choices, and other UI elements are referenced from the theme.
  • My pull request is focused and addresses a single, specific feature.
  • If there are UI changes, I have attached a screenshot or video to this PR.
Screenshot 2026-03-30 at 10 08 30 AM

@Innagl Innagl added this to the 2.3 milestone Mar 30, 2026
@Innagl Innagl added enhancement New feature or request frontend Frontend related tasks/issues labels Mar 30, 2026
@Innagl Innagl self-assigned this Mar 30, 2026
Copy link
Copy Markdown
Member

@Br0wnHammer Br0wnHammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Br0wnHammer Br0wnHammer merged commit 2a04fd3 into develop Mar 31, 2026
3 of 4 checks passed
@Br0wnHammer Br0wnHammer deleted the feature/new-training-modal-replace-inline-validation-with-generic-hook branch March 31, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Frontend related tasks/issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New training modal: replace local inline validateForm with shared hook

2 participants