fix(build): resolve all TypeScript build errors in frontend#3646
Closed
gorkem-bwl wants to merge 1 commit intodevelopfrom
Closed
fix(build): resolve all TypeScript build errors in frontend#3646gorkem-bwl wants to merge 1 commit intodevelopfrom
gorkem-bwl wants to merge 1 commit intodevelopfrom
Conversation
## Changes - Add vite/client reference to env.vars.ts for import.meta.env types - Add SVG declarations.d.ts reference to vite-env.d.ts for ReactComponent exports - Add vite-env.d.ts references in store.ts and deploymentHelpers.ts for __APP_VERSION__ - Fix test mock types to match updated auth slice (isSuperAdmin, activeOrganizationId) - Fix createElement calls in test files to pass children in props object - Remove unused imports in test files (fireEvent, within) - Fix Field test to use document.querySelector instead of non-existent queryByClassName - Prefix unused variable in Dashboard (superAdminHasNoOrgs -> _superAdminHasNoOrgs) - Fix test/setup.ts type cast - Remove stale Event.js file ## Result Both `cd Servers && npm run build` and `cd Clients && npm run build` pass with zero errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan