Add subtitleTrack and closedCaptions properties to CUES_PARSED event#7843
Merged
Add subtitleTrack and closedCaptions properties to CUES_PARSED event#7843
CUES_PARSED event#7843Conversation
github-project-automation
Bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
5 tasks
github-project-automation
Bot
moved this from Top priorities
to Done
in HLS.js Release Planning and Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Add
subtitleTrackandclosedCaptionsproperties toCUES_PARSEDevent.Why is this Pull Request needed?
Provides detailed track information like subtitles language or captions instream-id with
CUES_PARSEDotherwise not available outside ofNON_NATIVE_TEXT_TRACKS_FOUNDevent.Are there any points in the code the reviewer needs to double check?
New property names align with those already present in
NON_NATIVE_TEXT_TRACKS_FOUND.Resolves issues:
Resolves #6680
Checklist