Skip to content
This repository was archived by the owner on May 9, 2026. It is now read-only.

🚇🩹 Fix test CI workflow #129

Merged
Benexl merged 7 commits into from
Aug 17, 2025
Merged

🚇🩹 Fix test CI workflow #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6895426
🚇🩹 Install dbus-python build dependencies
s-weigand Aug 17, 2025
c6b8cfc
❌ Run on feature-branch
s-weigand Aug 17, 2025
66b2473
🚇🩹 Install libglib2.0-dev
s-weigand Aug 17, 2025
7b43145
🩹 Relock uv.lock file due to changed package name
s-weigand Aug 17, 2025
f6fedf0
🧹 Remove unused TYPE_CHECKING import
s-weigand Aug 17, 2025
4d50cff
🧹 Ignore blank except ruff rule
s-weigand Aug 17, 2025
4b310e6
Revert "❌ Run on feature-branch"
s-weigand Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Install dbus-python build dependencies
run: |
sudo apt-get update
sudo apt-get -y install libdbus-1-dev libglib2.0-dev

- name: Install uv
uses: astral-sh/setup-uv@v3
with:
Expand Down
3,369 changes: 3,123 additions & 246 deletions uv.lock
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion viu_cli/cli/commands/anilist/commands/downloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import json
from typing import TYPE_CHECKING

import click

Expand Down
4 changes: 2 additions & 2 deletions viu_cli/cli/service/download/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def _execute_download_job(self, media_item: MediaItem, episode_number: str):
timeout=self.app_config.general.desktop_notification_duration
* 60,
)
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except Exception: # noqa: E722

Copilot uses AI. Check for mistakes.
pass
logger.info(message)
else:
Expand All @@ -325,7 +325,7 @@ def _execute_download_job(self, media_item: MediaItem, episode_number: str):
app_icon=app_icon,
timeout=self.app_config.general.desktop_notification_duration * 60,
)
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except Exception:

Copilot uses AI. Check for mistakes.
pass
logger.error(
message,
Expand Down
10 changes: 5 additions & 5 deletions viu_cli/cli/service/feedback/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def success(self, message: str, details: Optional[str] = None) -> None:
timeout=self.app_config.general.desktop_notification_duration * 60,
)
return
except:
except: # noqa: E722
logger.warning("Using rofi without plyer for notifications")

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
logger.warning("Using rofi without plyer for notifications")
except ImportError:
logger.warning("plyer not installed; using rofi without desktop notifications")
except Exception as e:
logger.warning(f"Failed to send desktop notification: {e}")

Copilot uses AI. Check for mistakes.
if details:
console.print(f"{main_msg}\n[dim]{details}[/dim]")
Expand All @@ -70,7 +70,7 @@ def error(self, message: str, details: Optional[str] = None) -> None:
timeout=self.app_config.general.desktop_notification_duration * 60,
)
return
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except (ImportError, Exception):

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
if details:
console.print(f"{main_msg}\n[dim]{details}[/dim]")
Expand All @@ -97,7 +97,7 @@ def warning(self, message: str, details: Optional[str] = None) -> None:
timeout=self.app_config.general.desktop_notification_duration * 60,
)
return
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except Exception:

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
if details:
console.print(f"{main_msg}\n[dim]{details}[/dim]")
Expand All @@ -123,7 +123,7 @@ def info(self, message: str, details: Optional[str] = None) -> None:
timeout=self.app_config.general.desktop_notification_duration * 60,
)
return
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except Exception:

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
if details:
console.print(f"{main_msg}\n[dim]{details}[/dim]")
Expand Down Expand Up @@ -179,7 +179,7 @@ def pause_for_user(self, message: str = "Press Enter to continue") -> None:
timeout=self.app_config.general.desktop_notification_duration * 60,
)
return
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except (ImportError, Exception):

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
click.pause(f"{icon}{message}...")

Expand Down
4 changes: 2 additions & 2 deletions viu_cli/libs/selectors/rofi/selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def choose(self, prompt, choices, *, preview=None, header=None):
app_icon=str(ICON_PATH),
timeout=2 * 60,
)
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Suggested change
except: # noqa: E722
except Exception:

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
sys.exit(1)

Expand Down Expand Up @@ -132,7 +132,7 @@ def choose_multiple(
app_icon=str(ICON_PATH),
timeout=2 * 60,
)
except:
except: # noqa: E722

Copilot AI Aug 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bare except clauses is a poor practice as it catches all exceptions including system exit and keyboard interrupts. Consider catching specific exceptions like ImportError or Exception instead.

Copilot uses AI. Check for mistakes.
logger.warning("Using rofi without plyer for notifications")
# HACK: force exit if no input
sys.exit(1)
Expand Down
Loading