cgen: guard coverage counter file creation#27075
Open
guweigang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard coverage counter file creation before writing coverage rows.
Root cause
The generated
vprint_coverage_stats()opened the counter CSV withfopen(...)and immediately passed the result tofprintf(...). If the coverage directory was not writable or was otherwise invalid,fopencould returnNULL, causing a segfault during_vcleanup().This also fixes a typo in the generated non-Windows timestamp assignment, where
ts.tv_nsecwas assigned tosecsinstead ofnsecs.Changes
vprint_coverage_stats()when the counter file cannot be opened.nsecs = ts.tv_nsec;for the monotonic timestamp nanoseconds field.Validation
./v -o ./v4 ./cmd/v./v4 -cov /private/tmp/vcov_as_file vlib/v/tests/fns/closure_struct_init_cov_regression_test.v./v4 -cov /private/tmp/vcov_ok vlib/v/tests/fns/closure_struct_init_cov_regression_test.v./v4 test vlib/v/gen/c/coutput_test.vgit diff --check