Skip to content

Add client to retrofit#33

Open
razavioo wants to merge 1 commit intovmadalin:masterfrom
razavioo:master
Open

Add client to retrofit#33
razavioo wants to merge 1 commit intovmadalin:masterfrom
razavioo:master

Conversation

@razavioo
Copy link
Copy Markdown

@razavioo razavioo commented Feb 2, 2021

Fixes bug of not adding the client to retrofit

@vmadalin
Copy link
Copy Markdown
Owner

vmadalin commented Feb 4, 2021

Hi @razavioo, first of all, thanks for your PR and your contribution. Looks amazing, the only point is to fix the related unit test that is currently failing regarding the build more exactly:

> Task :core:compileDevDebugUnitTestKotlin
e: /home/circleci/kotlin-sample-app/core/src/test/kotlin/com/vmadalin/core/di/NetworkModuleTest.kt: (58, 61): No value passed for parameter 'client'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants