Add configurable webhook HMAC secret#242
Open
allsanlawlas wants to merge 2 commits into
Open
Conversation
allsanlawlas
marked this pull request as ready for review
July 23, 2026 21:07
allsanlawlas
marked this pull request as draft
July 24, 2026 09:57
allsanlawlas
marked this pull request as ready for review
July 25, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional, dedicated webhook HMAC secret that can be generated and
activated from the payment gateway UI.
Settingtable.dedicated secret when configured.
active.
replace the active signing credential.
and rollback considerations.
Motivation
Webhook HMAC signatures currently reuse the payment gateway API key. A
separate secret reduces coupling between API authentication and webhook
verification, avoids sending the API key to callback receivers in dedicated
mode, and makes webhook-secret rotation safer.
Compatibility and security behavior
secret is explicitly activated.
no-store.X-Shkeeper-Api-Keyheader only whileAPI-key fallback is active.
Validation
61 passedon Python 3.11.61 passedon Python 3.13, matching the production Dockerfile runtime.payouts in dedicated-secret and API-key fallback modes.
generation, activation, replacement, and removal.
e4f8a9b2c1d8.smoke tested.
git diff --checkpassed.