fix(VTreeview): add aria-label to expand/collapse toggle buttons#22953
Closed
sridhar-3009 wants to merge 2 commits into
Closed
fix(VTreeview): add aria-label to expand/collapse toggle buttons#22953sridhar-3009 wants to merge 2 commits into
sridhar-3009 wants to merge 2 commits into
Conversation
sridhar-3009
force-pushed
the
fix/treeview-aria-expand-collapse-21585
branch
from
671a73e to
8647019
Compare
Contributor
|
closing in favor of #22903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21585
Problem
Screen readers announce VTreeview expand/collapse toggle buttons as just "Button" with no context about which node they control or what action they perform.
Solution
expandedprop toVTreeviewItemto track the open/collapsed state of a tree nodeuseLocaletoVTreeviewItemand setaria-labelon the toggleVBtnusing i18n keystreeview.expandandtreeview.collapselocale keys toen.tswith{0}placeholder for the node titleexpanded: isOpenfrom theVTreeviewChildrenactivator slot intolistItemPropsWith this change, screen readers will announce something like "Expand Fruits" or "Collapse Fruits" instead of just "Button".