refactor: remove react-server-dom-webpack/client alias#1995
Draft
hi-ogawa wants to merge 5 commits intowakujs:mainfrom
Draft
refactor: remove react-server-dom-webpack/client alias#1995hi-ogawa wants to merge 5 commits intowakujs:mainfrom
react-server-dom-webpack/client alias#1995hi-ogawa wants to merge 5 commits intowakujs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Member
That's actually intentional, and I hoped react-server-dom-vite to be real. Though, I agree the aliasing is counter-intuitive and not very straightforward. So, yeah, I can change that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1993 (comment)
Waku was still using
react-server-dom-webpack/clientinstead of accessing@vitejs/plugin-rsc/browserAPI even though they were forcefully aliased to the same thing via plugin.@vitejs/plugin-rscnow has a proper options types for RSC API surfaces (see vitejs/vite-plugin-react#1154) and it allows replacing directly without losing types.