fix: refine review-pr skill with evidence-backed rules from reviewer feedback#25
Draft
captainsafia wants to merge 1 commit into
Draft
fix: refine review-pr skill with evidence-backed rules from reviewer feedback#25captainsafia wants to merge 1 commit into
captainsafia wants to merge 1 commit into
Conversation
…feedback Add three new rules to the Review Scope section based on patterns observed in human reviewer feedback from the week of 2026-05-29 to 2026-06-05 across warpdotdev/warp-server PRs: 1. Verify symbols exist in full file context, not just the diff (PR #11601 — reviewer corrected bot for claiming a symbol was missing when it existed in the same file). 2. Calibrate severity for optimization/heuristic code vs correctness code (PR #11624 — reviewer noted the bot treated an optimization imperfection as a correctness bug). 3. Do not suggest infrastructure-dependent resources without confirming availability (PR #11668 — reviewer corrected bot for suggesting a field not yet provisioned via Terraform). No changes to review-spec: only one spec PR had human comments this week and they were clarifying Q&A with no actionable signal. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three new rules to the
review-prskill's Review Scope section, each backed by evidence from human reviewer feedback on warpdotdev/warp-server PRs in the week of 2026-05-29 to 2026-06-05.New rules
Verify symbols in full file context — Before claiming a symbol/function/pattern is missing, check the full file, not just the diff. (Evidence: PR #11601 — reviewer corrected bot for claiming a symbol didn't exist when it was in the same file.)
Calibrate severity for optimization code — When reviewing optimization or heuristic code (caches, early exits, approximate checks), calibrate severity to the tolerance of the use case. Don't treat imperfect optimizations as correctness bugs. (Evidence: PR #11624 — reviewer noted the bot missed the nuance that the check was "just an optimization" and didn't need to be perfect.)
Don't suggest infrastructure-dependent resources — Don't suggest switching to fields/APIs/resources that depend on external infrastructure (e.g. Terraform) without confirming they're available. (Evidence: PR #11668 — reviewer corrected bot for suggesting a field not yet provisioned via Terraform.)
What was not changed
cc @captainsafia
Conversation: https://staging.warp.dev/conversation/6f40db5f-b328-4025-8449-6460076103c3
Run: https://oz.staging.warp.dev/runs/019e984c-681e-72bd-9693-f349a3ad1438
This PR was generated with Oz.
Co-Authored-By: Oz oz-agent@warp.dev