Add Typesafe <NavLink> component to Wasp #4104
Open
FranjoMindek wants to merge 3 commits intomainfrom
Open
Conversation
Deploying wasp-docs-on-main with
|
| Latest commit: |
cb61dfc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f617ab27.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://franjo-typesafe-navlinks.wasp-docs-on-main.pages.dev |
FranjoMindek
had a problem deploying
to
railway-deploy-test
GitHub Actions
Failure
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
had a problem deploying
to
railway-deploy-test
GitHub Actions
Failure
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Failure
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Failure
FranjoMindek
had a problem deploying
to
railway-deploy-test
GitHub Actions
Failure
FranjoMindek
had a problem deploying
to
railway-deploy-test
GitHub Actions
Failure
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4101
Pretty much identical to existing
<Link>component, just wraps the<NavLink>instead. Much better DX for links reacting to navigation state.Also updated our PUBLIC API spreadsheet.
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.