feat: enable createRequire parser by default for node targets#14826
feat: enable createRequire parser by default for node targets#14826JSerFeng wants to merge 1 commit into
Conversation
Deploying rspack with
|
| Latest commit: |
4b90ccf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d85ee92f.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-enable-create-require-bvkj.rspack-v2.pages.dev |
📦 Binary Size-limit
⏳ The base commit triggered a linux binding build, but its binary size data has not been generated yet, so the size comparison is skipped. Please re-run this workflow once the ecosystem-benchmark data for that commit is published. Warning Reference only — not the real baseline. The base commit's data isn't ready yet, so this compares against the nearest earlier commit that has data ( 🙈 Size remains the same at 66.60MB |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will degrade performance by 3.88%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | rust@create_concatenate_module |
14.4 ms | 15 ms | -3.88% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/enable-create-require-node-webpack-default (4b90ccf) with codex/defer-create-require-argument-walk (f6879c9)
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
ea71bf4 to
b64f56b
Compare
b64f56b to
4b90ccf
Compare
Summary
module.parser.javascript.createRequiretotruewhen the resolved target is Node.js-compatible, matching webpack’screateRequire = isNodedefaultjavascript.requireResolve; explicitcreateRequireconfiguration still takes precedencecreateRequire: truefrom the existing Node integration case and the two ESMcreateRequireregression casesrequireResolve: falseESM case validate the parser delegation fix from fix: parse preserved createRequire arguments #14813 under the new Node defaultThis PR is stacked on #14813 and should be retargeted to
mainafter #14813 merges.Validation
corepack pnpm run build:jsCARGO_TARGET_DIR=/Users/bytedance/libs/rspack/target corepack pnpm run build:binding:devtests/rspack-testsuite: 46 files, 8812 tests passed, 4 skippedcorepack pnpm run lint:jsgit diff --check