refactor(#50): remove superseded computePose / invertPose / computeGLviewMatrix()#58
Merged
Merged
Conversation
…Matrix() These were WebARKit's own pose-math path, superseded by cameraPoseFromPoints + the #55 pose3d fix: - computePose() -- its only call site was already commented out; cameraPoseFromPoints is the live pose solve. - invertPose() -- only ever called by computePose(). - computeGLviewMatrix() (no-arg) -- uncalled; the live path uses the computeGLviewMatrix(cv::Mat&) overload (kept). Also drops the dangling commented computePose call in WebARKitTracker.cpp. Behavior-neutral; the live pose/GL-view path (cameraPoseFromPoints, getTrackablePose, updateTrackable, computeGLviewMatrix(cv::Mat&)) is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added
enhancement
4 tasks
kalwalt
moved this from Review in progress
to Reviewer approved
in New markerless image tracking
github-project-automation
Bot
moved this from Reviewer approved
to Done
in New markerless image tracking
kalwalt
added a commit
to webarkit/webarkit-testing
that referenced
this pull request
Jun 20, 2026
Companion to webarkit/WebARKitLib#58. Bump the submodule to the commit removing the superseded computePose/invertPose/computeGLviewMatrix()-noarg, and rebuild build/ + dist/ (emscripten output is not byte-reproducible). docs/audit-dead-code-issue50.md: move the computePose cluster from "pending" to "removed (#58)"; the #50 audit is now complete (everything else decided KEEP). Verified: static example tracks (pyrLevel 1, 1000 matches); live pose path unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
kalwalt
added a commit
to webarkit/webarkit-testing
that referenced
this pull request
Jun 21, 2026
Companion to webarkit/WebARKitLib#58. Bump the submodule to the commit removing the superseded computePose/invertPose/computeGLviewMatrix()-noarg, and rebuild build/ + dist/ (emscripten output is not byte-reproducible). docs/audit-dead-code-issue50.md: move the computePose cluster from "pending" to "removed (#58)"; the #50 audit is now complete (everything else decided KEEP). Verified: static example tracks (pyrLevel 1, 1000 matches); live pose path unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final #50 cleanup item (Tier 3). Removes WebARKit's own superseded pose-math, now fully replaced by
cameraPoseFromPoints+ the #55pose3dfix.Removed
computePose()— its only call site was already commented out;cameraPoseFromPointsis the live pose solve.invertPose()— only ever called bycomputePose().computeGLviewMatrix()(no-arg) — uncalled; the live path uses thecomputeGLviewMatrix(cv::Mat&)overload (kept).computePosecall inWebARKitTracker.cpp.Not ArtoolkitX-derived
Unlike the OCVT symbols we deliberately kept (
CleanUp,markerRoi, etc.), these are WebARKit's own pose helpers, genuinely superseded — so removing them de-duplicates rather than diverging from upstream design.Compatibility
Behavior-neutral. The live pose/GL-view path (
cameraPoseFromPoints→getTrackablePose→updateTrackable→computeGLviewMatrix(cv::Mat&)) is untouched;pose3dis still populated bycameraPoseFromPoints(#55). Brace balance verified.Refs #50. After this, the #50 audit is complete (everything else was decided KEEP).
🤖 Generated with Claude Code