Skip to content

chore(#50): submodule bump for Tier-3 pose-math removal + close-out doc #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalwalt merged 2 commits into from
Jun 20, 2026
Merged

chore(#50): submodule bump for Tier-3 pose-math removal + close-out doc #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c2fd2a
chore(#50): bump submodule (Tier-3 pose-math removal) + rebuild
kalwalt Jun 20, 2026
9538f9f
chore: bump WebARKitLib to merged dev (e6f87fa)
kalwalt Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docs/audit-dead-code-issue50.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,12 @@ and `arglCameraViewRHf(cv::Mat)` overloads, `webarkitGetVersion(char**)` + the
`WEBARKIT_HEADER_VERSION_MAJOR/MINOR/TINY/DEV` constants, `N`, `featureDetectPyramidLevel`,
and `grayscale()` — kept as plausible public API / OCVConfig parity.

### Pending decision
### Removed — webarkit/WebARKitLib#58 (Tier 3)
- `computePose` / `invertPose` / `computeGLviewMatrix()` (no-arg) — WebARKit's own
pose math, superseded by `cameraPoseFromPoints` + the #55 `pose3d` fix. Not yet
removed; awaiting a keep/remove call.
pose math, superseded by `cameraPoseFromPoints` + the #55 `pose3d` fix. Removed
(behavior-neutral; the live `cameraPoseFromPoints` → `getTrackablePose` →
`updateTrackable` → `computeGLviewMatrix(cv::Mat&)` path is unchanged). With this,
the #50 audit is complete — every remaining flagged symbol was decided KEEP.

---

Expand Down
2 changes: 1 addition & 1 deletion emscripten/WebARKitLib
Open in desktop
Submodule WebARKitLib updated 3 files
+5 −54 WebARKit/WebARKitPattern.cpp
+0 −1 WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp
+0 −9 WebARKit/include/WebARKitPattern.h