Skip to content

Extend advanced routing docs with new features added by the RFC#13890

Open
matthewp wants to merge 3 commits into
mainfrom
advanced-routing-types
Open

Extend advanced routing docs with new features added by the RFC#13890
matthewp wants to merge 3 commits into
mainfrom
advanced-routing-types

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

Description (required)

Adds new docs for:

  • fetchFile option
  • extending Provider types
  • the Fetchable. type.

Related issues & labels (optional)

Associated with withastro/astro#16723

@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 5c7dd7a
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a060fe5e15cfe000809bea2
😎 Deploy Preview https://deploy-preview-13890--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 14, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/advanced-routing.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall but I left a few comments (section out of place, missing since, and a code snippet that looks a bit odd to me).

And, I see you have updated src/content/docs/en/reference/configuration-reference.mdx here but the content is different from packages/astro/src/types/public/config.ts. I think this is great to show the two examples but we'll need to apply the same changes in packages/astro/src/types/public/config.ts since this file is auto-generated.

Comment thread src/content/docs/en/reference/experimental-flags/advanced-routing.mdx Outdated
Comment thread src/content/docs/en/reference/configuration-reference.mdx Outdated
Comment thread src/content/docs/en/reference/configuration-reference.mdx Outdated
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ArmandPhilippot ArmandPhilippot added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label May 14, 2026
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants