Skip to content

rename CW LED descriptions to more commonly used CCT#5612

Open
DedeHai wants to merge 2 commits into
wled:mainfrom
DedeHai:rename_CW_to_CCT
Open

rename CW LED descriptions to more commonly used CCT#5612
DedeHai wants to merge 2 commits into
wled:mainfrom
DedeHai:rename_CW_to_CCT

Conversation

@DedeHai
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai commented May 13, 2026

this is a suggestion to rename "CW" into "CCT"

@intermittech what do you think? Open for discussion

Summary by CodeRabbit

  • Documentation
    • Updated LED type names and color-channel labels for several LED types to clarify RGBCCT support.
    • Clarified wording that appears in the LED types JSON API so displayed names better reflect color-channel capabilities.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50f14b7c-b56f-4c51-99bb-b3a4bc103575

📥 Commits

Reviewing files that changed from the base of the PR and between 175d97d and 3519fef.

📒 Files selected for processing (1)
  • wled00/bus_manager.cpp

Walkthrough

LED type display names and inline bus-method comments were updated to use CCT-style channel naming (e.g., “RGBCCT”, “GRBCCT”) and some RGB/RGBW descriptors were reformatted across two files.

Changes

LED Type Naming Standardization

Layer / File(s) Summary
LED Type Name API Update
wled00/bus_manager.cpp
BusDigital::getLEDTypes() updated human-readable name strings for multiple LED types, reformatting RGB/RGBW descriptors and renaming CCT-capable variants to use “RGBCCT …”.
Documentation and Comment Labels
wled00/bus_wrapper.h
Inline comments and section labels for ESP32/ESP8266 bus methods were updated to reflect CCT channel naming for FW1906, WS2805, SM16825; file now includes a UTF-8 BOM on #pragma once.

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels: enhancement

Suggested reviewers:

  • softhack007
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: renaming CW (Cold White) to CCT (Correlated Color Temperature) in LED type descriptions, which is the primary focus of both modified files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@intermittech
Copy link
Copy Markdown
Contributor

Oh, I am 100% for that!

Any term other than RGBCCT or RGB+CCT is confusing in my opinion. WW is generally used for "Warm White" and CW is often used for "Cold White", that's fine. Things we're okay up until RGBW but then people starting calling it RGBWW or RGBCW sometimes, denoting the particular color temperature of that strip but there things went wrong, sometimes using RGBCW as referring to dual white also since the C and W is in there, very confusing. I've also seen it written as RGBWWCW, less confusing but still a bit meh in my opinion.

CCT is clear what it means, dual white color temperature
RGBCCT is also clear what it means, R+G+B with dual white

RGBW stays as is, R+G+B with a single white (whatever temperature)

I sometimes use the distinction of RGBCCT and RGB+CCT if the white is integrated into the same package, or external, but for the software side, that really doesn't matter, CCT and RGBCCT is the correct way to do it in my opinion.

Comment thread wled00/bus_manager.cpp Outdated
{TYPE_APA106, "D", PSTR("APA106/PL9823")},
{TYPE_TM1914, "D", PSTR("TM1914")},
{TYPE_FW1906, "D", PSTR("FW1906 GRBCW")},
{TYPE_FW1906, "D", PSTR("RGBCCT FW1906/WS2811")},
Copy link
Copy Markdown
Member

@softhack007 softhack007 May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Minor) this entry uses "RGBCCT" as prefix to the chip name, but the other entries have that as postfix (after the chip name). Was this intended?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, as it applies to multiple strips, could also add this to the others that are frequently used, i.e.

  • RGB WS281x
  • RGB 400kHz
  • RGBW SK6812/WS2814
  • RGBW UCS8904
  • RGBCCT WS2805 (note: uses slightly faster timing)
  • RGBCCT SM16825

etc.

Copy link
Copy Markdown
Member

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me 👍
Same as @intermittech says, I remember there were different namings around when RGB strips got white as an extra LED. CCT seems to be the term that "survived".

To be discussed: maybe we could always use the RGB+" naming?

  • RGB (no white)
  • RGB+W (single white - either cold or warm white)
  • RGB+CCT (both warm and cold white)
  • White (single white)
  • CCT (cold+warm)

Not sure what to do with "CCT + Amber" strips that have three white channels?

@intermittech
Copy link
Copy Markdown
Contributor

intermittech commented May 14, 2026

Oh that is a good one @softhack007, there is a SK6812 WWA which has Warm, Cold and Amber White, I'd say it's so much of an exception (and the only one of that sort as far as I am aware) that it shouldn't define the naming for the rest. So maybe we just keep it as an exception to the rule, I think that's fine.

It seems the PWM naming was done by another developer and that it's 5 channel mode is called RGB+CCT, maybe just clean it all up and make it the same and I'd personally choose for RGBCCT then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants