Skip to content

Clean up setup.py #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roberthdevries wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −10
Open

Clean up setup.py #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ dev = [
"types-cffi",
]

[tool.setuptools.packages.find]
include = ["wolfcrypt", "wolfcrypt._ffi"]

[tool.ruff]
# Exclude a variety of commonly ignored directories.
exclude = [
Expand Down
11 changes: 1 addition & 10 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import os
import re
import sys
from setuptools import setup, find_packages
from setuptools import setup

os.chdir(os.path.dirname(sys.argv[0]) or ".")

Expand All @@ -47,20 +47,11 @@
with open("README.rst") as readme_file:
long_description = readme_file.read()

with open("LICENSING.rst") as licensing_file:
long_description = long_description.replace(".. include:: LICENSING.rst\n",
licensing_file.read())

setup(
name="wolfcrypt",
version=verstr,
long_description=long_description,
long_description_content_type='text/x-rst',

packages=find_packages(),

setup_requires=["cffi>=1.17"],
cffi_modules=["./scripts/build_ffi.py:ffibuilder"],

package_data={"wolfcrypt": ["*.dll", "**/*.pyi", "py.typed"]},

@sebastian-carpenter sebastian-carpenter Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like '.dll' is being dropped from the build. The '.pyi' and 'py.typed' should be fine to remove since I believe they're implicit but a rule needs to be added to pyproject.toml to continue copying '*.dll'.

@roberthdevries roberthdevries Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The include line on line 50 of pyproject.toml specifies the directories to include in the wheel. On Linux it includes the .so the file by default. So my hopes are that on Windows setuptools would also do this for .dll files by default.
Unfortunately I do not have a development environment under Windows available. Could someone at your end try to run uv build --wheel on a Windows system?

@sebastian-carpenter sebastian-carpenter Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be doable. I'll get back to you once I've tested it.

)
Loading