Skip to content

Fix universal links for www domains - #17682

Open
joshheald wants to merge 5 commits into
trunkfrom
WOOMOB-3669-fix-universal-links
Open

Fix universal links for www domains#17682
joshheald wants to merge 5 commits into
trunkfrom
WOOMOB-3669-fix-universal-links

Conversation

@joshheald

@joshheald joshheald commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes WOOMOB-3669.

Universal links could open in Safari, because only the bare domains were declared in the app entitlements, without www. This adds both www hosts to every iOS build configuration and re-enables the Universal Link UI tests.

The tests open links through XCUIDevice.shared.system, which runs through iOS Universal Link resolution without depending on Safari UI or accessibility identifiers. This should help address the flakiness of the tests mentioned previously.

Test Steps

  1. bundle exec rake mocks
  2. Run UniversalLinksTests from the WooCommerceUITests scheme.
  3. Confirm the orders link opens order 3337 in the app.
  4. Confirm the payments link opens the Payments screen in the app.

Verified on iPad and iPhone using iOS 26.3.1 and 18.6,


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald
joshheald requested a review from a team as a code owner August 10, 2026 13:04
@joshheald joshheald added type: bug A confirmed bug. feature: core Core work. See "category: tooling" and "category: architecture" category: ui tests Related to UI testing. run ui tests Triggers Buildkite UI tests for this PR. labels Aug 10, 2026
@joshheald joshheald added this to the 25.5 milestone Aug 10, 2026
@wpmobilebot

wpmobilebot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr17682-316321a
Version25.4
Bundle IDcom.automattic.alpha.woocommerce
Commit316321a
Installation URL74qqlqoo0d530
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@joshheald
joshheald requested a review from iamgabrielma August 10, 2026 17:41

@mokagio mokagio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshheald I noticed the iOS UI tests failed in CI but the reason was POS, not universal links. I retried, twice. POS remained red and universal links green.

Image

There's a flaky label in Buildkite but I think it might be due to the prior flaky behavior because they were green in the three runs.

@iamgabrielma

Copy link
Copy Markdown
Contributor

There's a flaky label in Buildkite but I think it might be due to the prior flaky behavior because they were green in the three runs.

This should be fixed now, I'll merge trunk here to confirm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ui tests Related to UI testing. feature: core Core work. See "category: tooling" and "category: architecture" run ui tests Triggers Buildkite UI tests for this PR. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants