Skip to content

Removed deprecated features / properties#2056

Draft
CastagnaIT wants to merge 10 commits into
xbmc:Piersfrom
CastagnaIT:depcrecations
Draft

Removed deprecated features / properties#2056
CastagnaIT wants to merge 10 commits into
xbmc:Piersfrom
CastagnaIT:depcrecations

Conversation

@CastagnaIT

@CastagnaIT CastagnaIT commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Description

List of deprecated properties that has been removed, and explanation for the alternatives


DRM properties:

inputstream.adaptive.license_type
inputstream.adaptive.license_key
inputstream.adaptive.license_data
inputstream.adaptive.server_certificate
inputstream.adaptive.license_flags
inputstream.adaptive.pre_init_data

addons that still use deprecated properties must migrate to the new:
inputstream.adaptive.drm_legacy or inputstream.adaptive.drm
wiki: https://github.com/xbmc/inputstream.adaptive/wiki/Integration-DRM


inputstream.adaptive.live_delay

This property has been moved on inputstream.adaptive.manifest_config
wiki: https://github.com/xbmc/inputstream.adaptive/wiki/Integration


inputstream.adaptive.license_url
inputstream.adaptive.license_url_append

These properties used for PVR, are no longer needed, because the Kodi bug has been already solved on Kodi 22


inputstream.adaptive.original_audio_language

This property has been moved on inputstream.adaptive.config
wiki: https://github.com/xbmc/inputstream.adaptive/wiki/Integration


Other cleanups-removal

  • Removed Widevine HB wrapper commented code
    //! @todo: the support to binary license data (with HB) that start with "\r\n\r\n" has not been reintroduced with the
    //! rework of this code, this is a old unclear addition, seem there are no info about this on web,
    //! and seem no addons use it, so for now is removed, if in the future someone complain about this lack
    //! will be possible reintroduce it and include more clear info about this use case.
    // if (data.compare(0, 4, "\r\n\r\n") == 0)
    // data.erase(0, 4);
  • Removed HLS "renew license url" add-on callbacks commented code
  • [Dash] Removed support for custom forced attribute for <Role> with scheme urn:mpeg:dash:role:2011
  • [AdaptiveStream] Removed code with fixed size sidx, the specific use case is unknown; it's probably just leftover code from the past that wasn't managed properly
  • [SmoothTree] Removed unused InsertLiveFragment implementation, we currently manage updates by periodically downloading the updated manifest
  • [AdaptiveStream] Removed adaptive buffering code, there is no plan to reimplement this soon

Motivation and context

All of these features were already planned to be removed for Kodi v23, no further support will be provided

All add-ons that still use some of these deprecated properties, must migrate to use the new one

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Breaking change fix or feature that will cause existing functionality to change v23 Q* labels Jun 14, 2026
@kodiai

kodiai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Decision: APPROVE

Issues: none

Evidence:

  • Review prompt covered 12 changed files.
  • Review scope note: output was scoped by prompt budget limits; Review Details include bounded counts only.
Review Details
  • Review plan: ready hash=a8c010178fbc route=standard task=review.full files=12 lines=502(local-diff) budget=na/803s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred doctrine=disabled/0/0/0 reasons=disabled

  • Review reducer: ready input=0 kept=0 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0 doctrine=disabled/0/0/0 reasons=disabled

  • Review candidates: shadow recorded=0 rejected=0 errors=0 artifact=absent repo=xbmc-inputstream.adaptive pr=2056 key=kodiai-review-output:v1:inst-109141824:xbmc-inputstream.adaptive:pr-2056:action- delivery=93462810-6810-11f1-8c92-1c10acbffae0

  • Review candidate publication: mode=blocked approved=0 rewritten=0 publishable=0 nonPublishable=0 fixBlocked=0 published=0 directFallback=0 reasons=no-candidate-publication-path,approval-blocked movedToDetails=0 detailsOmitted=0 buckets=blocked:1:approval-blocked+no-candidate-publication-path

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:ce20f75bf8661c592a6c685a18d105d8; recordKey=candidate-publication-record:ce20f75bf8661c592a6c685a18d105d8; correlationKey=candidate-publication-bridge:ec3f62f32427a18dac9916df2ea960bf; source=review-handler-publication; candidateRef=candidate-publication-summary-367677ce; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review finding lifecycle: status=normalized; counts=input:0,recorded:0,rejected:0,unsafeInputFields:0; correlation=repo:y,pull:y,reviewOutputKey:y,deliveryId:y,commit:n; statuses=detected:0,open:0,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0; severity=critical:0,major:0,medium:0,minor:0; actionability=actionable:0,needs-human-review:0,needs-reproduction:0,blocked:0,not-actionable:0; reasons=none; rejected=none; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Review validation truth: status=empty; counts=detected:0,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0,open:0,uncertain:0,inputFindings:0,unsafeInputFields:0; evidence=fresh:0,stale:0,missingValidation:0,missingRevalidation:0; reasons=none; refs=none; correlation=reviewOutputKey:y,deliveryId:y; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,replacementText:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Files reviewed: 12

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +36 -466

  • Profile: minimal (auto, lines changed: 502)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=4c03f9fa8f55ec77 deliveryId=93462810-6810-11f1-8c92-1c10acb… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • Review completed: 2026-06-14T16:53:29.186Z

  • Total wall-clock: 7m 6s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 1.2s
    • retrieval/context assembly: 3.7s
    • executor handoff: 36s
    • remote runtime: 6m 19s
    • publication: 2.7s
  • Tokens: 3,450 in / 14,258 out | 0.4710

  • Keyword parsing: No keywords detected

  • Budget behavior: scoped (prompt-budget-limited).

  • Prompt budget: 5 sections, 1 trimmed, 0 bypassed, 5521 trimmed tokens.

  • Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed.

  • Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Breaking change fix or feature that will cause existing functionality to change v23 Q*

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant