Fix C-strings usage.#73
Open
igankevich wants to merge 1 commit into
Open
Conversation
titusz
added a commit
to iscc/iscc-tika
that referenced
this pull request
Mar 29, 2026
Use NUL-terminated C-string literals (c"...") instead of Rust str pointers for JVM options. Without NUL terminators the strings worked accidentally but could cause memory issues when processing large numbers of files. Also replaces heap-allocated Vec with a stack array and fixes the missing hyphen in "-Djava.awt.headless=true". Based on: yobix-ai/extractous#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how options are passed to GraalVM. They should use NUL-terminated strings to not have memory issues. Without NULs it works accidentally, at least this is what I experienced when extracting large number of files.
Besides that PR replaces fixed-size
Vecwith an array to avoid memory allocation.