Add pytest-cov to dev dependency group#846
Merged
Merged
Conversation
The shared pytest addopts include --cov=numcodecs, so every dependency group that runs pytest needs pytest-cov. After the test-zarr-* groups were deduped to include the dev group, pytest-cov was no longer pulled in, breaking external runners (e.g. zarr-python's numcodecs codec tests job) with "unrecognized arguments: --cov=numcodecs". Put pytest-cov in dev so all groups that include it get coverage support. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared pytest
addoptsinpyproject.tomlinclude--cov=numcodecs --cov-report xml, so every dependency group that runs pytest needspytest-cov.After #844 deduped the
test-zarr-*groups to include thedevgroup,pytest-covwas no longer pulled in (thedevgroup only had plainpytest). This broke external runners that install those groups — notably zarr-python's "numcodecs zarr3 codec tests" job, which fails with:(See zarr-developers/zarr-python#3885 checks.)
Fix
Add
pytest-covto thedevdependency group. Since every test group includesdev, all internal and external runners now get coverage support.🤖 Generated with Claude Code