Skip to content

cmake: install a fitting config header#709

Open
nolange wants to merge 1 commit into
zeux:masterfrom
nolange:cmake-install-config-header
Open

cmake: install a fitting config header#709
nolange wants to merge 1 commit into
zeux:masterfrom
nolange:cmake-install-config-header

Conversation

@nolange

@nolange nolange commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

use a header with the correct defines, so
the defines fit to the compiled library.

I have to use this when creating a sysroot / sdk for later builds. the options are currently just discarded.

Ideally the build would use the header too instead of defines, but there is no clean way,
as #include "pugiconfig.hpp" will pretty consistentely prefer the file next to it.
I could change this to always create from CMake, but I guess that breaks all the other build systems.

use a header with the correct defines, so
the defines fit to the compiled library.
@zeux

zeux commented Jun 13, 2026

Copy link
Copy Markdown
Owner

This can't be unconditional. It needs to be gated under PUGIXML_INSTALL_CONFIG option; I'm not sure if it's better to change PUGIXML_HEADERS or just adjust the installation code. Also at this point I wonder if the sysroot build even needs to use CMake; it looks like your use case requires a very custom configuration and a custom config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants