cmake: install a fitting config header#709
Open
nolange wants to merge 1 commit into
Open
Conversation
use a header with the correct defines, so the defines fit to the compiled library.
Owner
|
This can't be unconditional. It needs to be gated under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use a header with the correct defines, so
the defines fit to the compiled library.
I have to use this when creating a sysroot / sdk for later builds. the options are currently just discarded.
Ideally the build would use the header too instead of defines, but there is no clean way,
as
#include "pugiconfig.hpp"will pretty consistentely prefer the file next to it.I could change this to always create from CMake, but I guess that breaks all the other build systems.