feat: add a parameter for batch size when loading files or websites#136
Merged
sre-ci-robot merged 4 commits intozilliztech:masterfrom Mar 10, 2025
Merged
feat: add a parameter for batch size when loading files or websites#136sre-ci-robot merged 4 commits intozilliztech:masterfrom
sre-ci-robot merged 4 commits intozilliztech:masterfrom
Conversation
…n the embedding service, ensuring compatibility with services that have batch size limitations.
Collaborator
|
Welcome @droxer! It looks like this is your first PR to zilliztech/deep-searcher 🎉 |
Contributor
|
@droxer please fix the lint error |
Contributor
Author
Sure. |
Contributor
|
you can try to execute: make format |
Contributor
Author
@SimFG Done |
Contributor
Author
|
@SimFG added batch_size as a request params. P.S. If it’s not ideal to include them all in one PR, please let me know. |
Contributor
|
/lgtm |
Contributor
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droxer, SimFG The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameter for batch size when loading files or websites in the embedding service, ensuring compatibility with services that have batch size limitations.
e.g Aliyun Bailian Embedding Service requires the batch size should not exceed 10.
/assign @xiaofan-luan