fix: handle firecrawl SDK API change for ScrapeOptions import#262
Open
octo-patch wants to merge 1 commit intozilliztech:masterfrom
Open
fix: handle firecrawl SDK API change for ScrapeOptions import#262octo-patch wants to merge 1 commit intozilliztech:masterfrom
octo-patch wants to merge 1 commit intozilliztech:masterfrom
Conversation
…illiztech#255) The firecrawl-py SDK changed the location of ScrapeOptions across versions. Use a try/except chain to support all SDK versions gracefully.
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: octo-patch The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign @xiaofan-luan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255
Problem
The
firecrawl-pySDK changed whereScrapeOptionsis exported across major versions:from firecrawl import FirecrawlApp, ScrapeOptionsfrom firecrawl.types import ScrapeOptionsV1ScrapeOptionsat the top-level packageThis causes an
ImportError: cannot import name 'ScrapeOptions' from 'firecrawl'at startup, preventing the entire package from importing even when FireCrawl is not configured as the active web crawler.Solution
Wrap the import with a
try/exceptchain that tries each import path in order, so the module works across all firecrawl-py SDK versions.Testing
Verified that the module imports successfully with both old and new firecrawl-py package versions by simulating the import fallback paths.