Skip to content

feat: switch knowhere IO init to unified context pool API - #1596

Closed
CLiqing wants to merge 2 commits into
zilliztech:mainfrom
CLiqing:feat/unified-io-context-pool-api
Closed

feat: switch knowhere IO init to unified context pool API#1596
CLiqing wants to merge 2 commits into
zilliztech:mainfrom
CLiqing:feat/unified-io-context-pool-api

Conversation

@CLiqing

@CLiqing CLiqing commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add backend-agnostic SetIOContextPool(size_t) entrypoint in knowhere config
  • route disk IO pool initialization through unified IOContextPool API instead of AIO-specific path
  • keep compatibility by preserving existing config behavior while validating the new init path in unit tests

Test plan

  • Build knowhere in vecTool integration workspace (make engine=cardinal)
  • Verify runtime search flow still works (runVectool.sh --data=siftsmall --stage=search --index_type=HNSW --index_version=9)
  • Run full upstream knowhere CI suite

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CLiqing
To complete the pull request process, please assign chasingegg after the PR has been reviewed.
You can assign the PR to them by writing /assign @chasingegg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Apr 21, 2026

Copy link
Copy Markdown

@CLiqing 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Align DiskANN reader submit/completion and max-events path with unified IOContextPool so runtime search uses io_uring instead of legacy AIO syscalls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mergify

mergify Bot commented Apr 28, 2026

Copy link
Copy Markdown

@CLiqing e2e jenkins job failed, comment /run-e2e can trigger the job again.

@mergify

mergify Bot commented Apr 28, 2026

Copy link
Copy Markdown

@CLiqing e2e jenkins job failed, comment /run-e2e-sse can trigger the job again.

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

@CLiqing please rebase

@github-actions github-actions Bot added the stale label May 30, 2026
@github-actions github-actions Bot closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants