Skip to content

Upgrade faiss to 1.14.1+, commit 967eda65dec2515#1618

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
alexanderguzhva:upgrade_faiss_141_6
May 12, 2026
Merged

Upgrade faiss to 1.14.1+, commit 967eda65dec2515#1618
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
alexanderguzhva:upgrade_faiss_141_6

Conversation

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

As far as I understand, this finalizes Faiss introduction of dynamic dispatch

/kind improvement
issue: #1501

@mergify
Copy link
Copy Markdown

mergify Bot commented May 7, 2026

@alexanderguzhva e2e jenkins job failed, comment /run-e2e-sse can trigger the job again.

…83d0

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@mergify mergify Bot added the ci-passed label May 7, 2026
@@ -0,0 +1,481 @@
/*
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was added by this PR but has zero include references anywhere in the codebase. The actual implementation used by hamming.cpp and the per-ISA TUs is utils/hamming_distance/hamming_impl.h. This dead duplicate should be deleted to avoid the two implementations drifting apart over time.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the baseline faiss code, so this file should stay as is

@liliu-z
Copy link
Copy Markdown
Collaborator

liliu-z commented May 8, 2026

thirdparty/faiss/faiss/utils/pq_code_distance.h:0 This refactor replaced the old pq_code_distance_single/pq_code_distance_four symbols with pq_code_distance_8bit_single/pq_code_distance_8bit_four. The header was removed from the FAISS_HEADERS install list and its only test consumer migrated to the new impl/pq_code_distance/ includes, but the old file still exists on disk. It could mislead future maintainers. Consider deleting it or converting it to a compatibility forwarding header.

@alexanderguzhva
Copy link
Copy Markdown
Collaborator Author

thirdparty/faiss/faiss/utils/pq_code_distance.h:0 This refactor replaced the old pq_code_distance_single/pq_code_distance_four symbols with pq_code_distance_8bit_single/pq_code_distance_8bit_four. The header was removed from the FAISS_HEADERS install list and its only test consumer migrated to the new impl/pq_code_distance/ includes, but the old file still exists on disk. It could mislead future maintainers. Consider deleting it or converting it to a compatibility forwarding header.

same story. This is the baseline faiss, should it should not be touched

Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexanderguzhva,foxspy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c55ad73 into zilliztech:main May 12, 2026
13 checks passed
ihb2032 pushed a commit to ihb2032/knowhere that referenced this pull request May 14, 2026
…83d0 (zilliztech#1618)

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants